Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Carthage support. #288

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Fix Carthage support. #288

merged 1 commit into from
Jul 15, 2022

Conversation

Zandor300
Copy link
Member

@Zandor300 Zandor300 commented Sep 16, 2021 •
edited
Loading

Remove CocoaPodsVerification project to fix Carthage selecting that instead of the DeviceKit workspace.

Fixes #287
Fixes #316

@github-actions
Copy link

2 Warnings
⚠️ Big PR, consider splitting into smaller
⚠️ Plist changed, don't forget to localize your plist values

Generated by 🚫 Danger

@Zandor300 Zandor300 mentioned this pull request Sep 23, 2021
Closed
@Zandor300 Zandor300 mentioned this pull request Jul 6, 2022
Closed
@emartinson
Copy link

Hi! Any updates on this? This is very important fix.

@Zandor300 Zandor300 marked this pull request as ready for review July 14, 2022 11:54
denisenepraunig
denisenepraunig approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@denisenepraunig denisenepraunig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Zandor300

@denisenepraunig denisenepraunig merged commit 2d0b7b7 into master Jul 15, 2022
@pepas-everly
Copy link

thanks!

@Zandor300 Zandor300 deleted the fix/carthage-support branch October 31, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denisenepraunig denisenepraunig denisenepraunig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Zandor300 @emartinson @pepas-everly @denisenepraunig