Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: i2c: Add transfer timeout property to controller #129

Merged

Conversation

tleb
Copy link

@tleb tleb commented Feb 21, 2024

Add i2c-transfer-timeout-us property to i2c-controller.yaml signaling the number of microseconds to wait before considering an I2C transfer has failed. Unit is microseconds (µs).

See the original proposal on lkml for context, with its answers. Original proposal was to add the property to a specific I2C bus controller.

Draft because

  • Feedback from Linux I2C subsystem maintainers would be useful to confirm this goes in the right direction.
  • Should the prop be added to the not-required list? I am not familiar with this reverse syntax and its meaning.

@robherring
Copy link
Member

Draft because

* Feedback from Linux I2C subsystem maintainers would be useful to confirm this goes in the right direction.

Wolfram gave his Reviewed-by. Please add it here.

* Should the prop be added to the not-required list? I am not familiar with this reverse syntax and its meaning.

No, that is just saying those 2 properties are mutually exclusive.

Add 'i2c-transfer-timeout-us' property to i2c-controller.yaml signaling
the number of microseconds to wait before considering an I2C transfer
has failed.

Unit is microseconds (µs).

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
@tleb tleb force-pushed the i2c-controller-transfer-timeout branch from 8c2075f to 80ac48c Compare February 23, 2024 07:46
@tleb
Copy link
Author

tleb commented Feb 23, 2024

Reviewed-By Wolfram got added and I removed the draft status. Thanks Rob.

@tleb tleb marked this pull request as ready for review February 23, 2024 07:47
@robherring robherring merged commit eb9f5d3 into devicetree-org:main Feb 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants