Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Bulma, Excel, MATLAB, Minitab, Phalcon, R, RStudio, SPSS icons #116

Closed
wants to merge 4 commits into from
Closed

Conversation

Pmz94
Copy link

@Pmz94 Pmz94 commented Apr 26, 2018

Added new svg icons.
Need some help on how to add the font versions
Bulma, Excel, MATLAB, Minitab, Phalcon, R, RStudio, SPSS

@hasnat
Copy link

hasnat commented Aug 13, 2018

only 63ecdf1 is a good commit, rest are to be considered as conflicts.

Copy link
Contributor

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No point in translating an English only content to Spanish.

@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 8, 2020
@amacado amacado linked an issue Jun 8, 2020 that may be closed by this pull request
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please take a look at our updated contribution guidelines and pay special attention to:

  • Create a separated pull request for each icon (no matter how many variations)

As previously pointed out: There is no need to translate the readme.md to spanish ;-)

@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@Thomas-Boi Thomas-Boi added the stale For PRs that haven't had any activity for a while and old issues label Jan 6, 2021
@Thomas-Boi
Copy link
Member

Hello there,

We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves.

Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes.

Cheers,
Devicon Team

@Thomas-Boi Thomas-Boi changed the base branch from master to develop January 6, 2021 01:18
@Thomas-Boi
Copy link
Member

Hi @Pmz94 , are you still planning to work on this PR or should I take over? Our commit process has changed quite a bit as well but I don't mind guiding you through it

@Thomas-Boi Thomas-Boi closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection stale For PRs that haven't had any activity for a while and old issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for new icon
5 participants