Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: postman (original, original-wordmark) #1237

Merged
merged 5 commits into from
Jul 23, 2022
Merged

new icon: postman (original, original-wordmark) #1237

merged 5 commits into from
Jul 23, 2022

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jun 27, 2022 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #933 #1278 #159

Link to prove your SVG is correct and up-to-date.

https://www.postman.com/

Kilian PAQUIER and others added 2 commits June 27, 2022 22:18
new icon: postman (original, original-wordmark, plain, plain-wordmark…
d851291 
…) - fix #933
@Snailedlt
postman| fix transparent plain icons
df98428 
Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>
@kilianpaquier kilianpaquier marked this pull request as ready for review June 29, 2022 19:59
Snailedlt
Snailedlt requested changes Jul 2, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fill color is wrong according to their press/media page -> https://www.postman.com/company/press-media/

Needs to be changed in all .svg's and in devicon.json

image

devicon.json Outdated Show resolved Hide resolved
icons/postman/postman-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/postman/postman-plain.svg Outdated Show resolved Hide resolved
icons/postman/postman-original.svg Outdated Show resolved Hide resolved
icons/postman/postman-original.svg Outdated Show resolved Hide resolved
icons/postman/postman-original-wordmark.svg Outdated Show resolved Hide resolved
@Snailedlt
postman| changed svg colors according to postman media rules
7c142b6 
Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>
@kilianpaquier
Copy link
Contributor Author

Hello @Snailedlt, I've made the changes, you can close or not the threads 🙂

Snailedlt
Snailedlt previously approved these changes Jul 2, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Looks good to me now

@kilianpaquier kilianpaquier mentioned this pull request Jul 23, 2022
Closed
1 task
Snailedlt
Snailedlt approved these changes Jul 23, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️
Thanks for contributing! 💯

@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 23, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Snailedlt Snailedlt merged commit 463d3ff into devicons:develop Jul 23, 2022
@kilianpaquier kilianpaquier deleted the postman branch July 24, 2022 09:09
@Snailedlt Snailedlt mentioned this pull request Aug 9, 2022
Closed
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
new icon: postman (original, original-wordmark) (devicons#1237)
38fad8e 
* new icon: postman (original, original-wordmark, plain, plain-wordmark) - fix devicons#933

* postman| fix transparent plain icons

Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>

* postman| changed svg colors according to postman media rules

Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>

Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
new icon: postman (original, original-wordmark) (devicons#1237)
82b55d8 
* new icon: postman (original, original-wordmark, plain, plain-wordmark) - fix devicons#933

* postman| fix transparent plain icons

Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>

* postman| changed svg colors according to postman media rules

Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>

Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
new icon: postman (original, original-wordmark) (devicons#1237)
16490be 
* new icon: postman (original, original-wordmark, plain, plain-wordmark) - fix devicons#933

* postman| fix transparent plain icons

Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>

* postman| changed svg colors according to postman media rules

Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>

Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>
@lunatic-fox lunatic-fox mentioned this pull request Nov 16, 2022
Closed
6 tasks
@canaleal canaleal mentioned this pull request Sep 14, 2023
Closed
1 task
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kilianpaquier @Snailedlt