Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: faunadb (original, original-wordmark, line, line-wordmark) #1265

Merged
merged 6 commits into from
Aug 15, 2022
Merged

new icon: faunadb (original, original-wordmark, line, line-wordmark) #1265

merged 6 commits into from
Aug 15, 2022

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jul 12, 2022 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1262, #769

Link to prove your SVG is correct and up-to-date.

https://fauna.com/about
https://images.ctfassets.net/po4qc9xpmpuh/7itYmeRxmVGIXwwGWHrQU3/42f3e7fa7d39fab5b6222f6199f0203c/Fauna_Logo.svg

@kilianpaquier kilianpaquier changed the title new icon: faunadb (original, original-wordmark) - fix #1262 new icon: faunadb (original, original-wordmark) Jul 12, 2022
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 28, 2022
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 4, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
Snailedlt
Snailedlt previously approved these changes Aug 5, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thanks for your contribution! 🚀

Snailedlt
Snailedlt reviewed Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kilian-paquier merge conflicts need to be solved

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 12, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

Panquesito7
Panquesito7 approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for contributing. 🚀

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Elegant, Maintainable

@Panquesito7 Panquesito7 changed the title new icon: faunadb (original, original-wordmark) new icon: faunadb (original, original-wordmark, line, line-wordmark) Aug 15, 2022
@Panquesito7 Panquesito7 merged commit 13e10af into devicons:develop Aug 15, 2022
@kilianpaquier kilianpaquier deleted the faunadb branch August 18, 2022 17:28
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
new icon: faunadb (original, original-wordmark, line, line-wordmark) (d…
ab70ca3 
…evicons#1265)

* new icon: faunadb (original, original-wordmark) - fix devicons#1262, devicons#769

* faunadb| added line fonts
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
new icon: faunadb (original, original-wordmark, line, line-wordmark) (d…
671184b 
…evicons#1265)

* new icon: faunadb (original, original-wordmark) - fix devicons#1262, devicons#769

* faunadb| added line fonts
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
new icon: faunadb (original, original-wordmark, line, line-wordmark) (d…
ad0977f 
…evicons#1265)

* new icon: faunadb (original, original-wordmark) - fix devicons#1262, devicons#769

* faunadb| added line fonts
@lunatic-fox lunatic-fox mentioned this pull request Nov 24, 2023
Merged
1 task
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@Snailedlt Snailedlt Snailedlt approved these changes

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilianpaquier @Snailedlt @Panquesito7