Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: awk (original, original-wordmark, plain, plain-wordmark) #1312

Merged
merged 4 commits into from
Aug 7, 2022
Merged

new icon: awk (original, original-wordmark, plain, plain-wordmark) #1312

merged 4 commits into from
Aug 7, 2022

Conversation

Snailedlt
Copy link
Collaborator

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1304

Link to prove your SVG is correct and up-to-date.

https://en.wikipedia.org/wiki/AWK
https://commons.wikimedia.org/wiki/File:The-AWK-Programming-Language.svg

@Snailedlt
Copy link
Collaborator Author

The peek-bot keeps failing here. I think it's because I originally opened a PR to the master branch instead of develop, then changed it. I also tried closing the PR and making a new (this) PR, but still the same issue.
image
image

@devicons/maintainer Do any of you know of a way to fix this?

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 28, 2022
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 6, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@Snailedlt Snailedlt changed the title new icon: awk (original-wordmark,plain-wordmark) new icon: awk (original,original-wordmark,plain,plain-wordmark) Aug 6, 2022
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 6, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@Panquesito7 Panquesito7 changed the title new icon: awk (original,original-wordmark,plain,plain-wordmark) new icon: awk (original, original-wordmark ,plain, plain-wordmark) Aug 7, 2022
@Panquesito7 Panquesito7 changed the title new icon: awk (original, original-wordmark ,plain, plain-wordmark) new icon: awk (original, original-wordmark, plain, plain-wordmark) Aug 7, 2022
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 7, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@Panquesito7 Panquesito7 changed the title new icon: awk (original, original-wordmark, plain, plain-wordmark) new icon: awk (original, original-wordmark, plain, plain-wordmark) Aug 7, 2022
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Panquesito7
Panquesito7 approved these changes Aug 7, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 🚀

__
sema-logo  Summary: 👌 This code looks good  |  Tags: Maintainable

@Panquesito7 Panquesito7 merged commit a8fe865 into devicons:develop Aug 7, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@Snailedlt
new icon: awk (original, original-wordmark, plain, plain-wordmark) (d…
bff8da8 
…evicons#1312)

* add awk programming language (fix devicons#1304)

* add altname, and remove .vscode folder

* Update awk-plain-wordmark.svg

* Update awk-original-wordmark.svg
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@Snailedlt
new icon: awk (original, original-wordmark, plain, plain-wordmark) (d…
fa8e3c5 
…evicons#1312)

* add awk programming language (fix devicons#1304)

* add altname, and remove .vscode folder

* Update awk-plain-wordmark.svg

* Update awk-original-wordmark.svg
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@Snailedlt
new icon: awk (original, original-wordmark, plain, plain-wordmark) (d…
6dffb79 
…evicons#1312)

* add awk programming language (fix devicons#1304)

* add altname, and remove .vscode folder

* Update awk-plain-wordmark.svg

* Update awk-original-wordmark.svg
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@amacado amacado Awaiting requested review from amacado

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Snailedlt @Panquesito7