-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated links to contributing guidelines #1333
Merged
Panquesito7
merged 3 commits into
devicons:develop
from
Snailedlt:bugfix/update_links_to_contributing_md
Jul 29, 2022
Merged
updated links to contributing guidelines #1333
Panquesito7
merged 3 commits into
devicons:develop
from
Snailedlt:bugfix/update_links_to_contributing_md
Jul 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panquesito7
reviewed
Jul 28, 2022
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
requested changes
Jul 28, 2022
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snailedlt
added a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
* updated links to contributing guidelines fix devicons#1328 * implement review suggestions by @Panquesito7 Co-authored-by: David Leal <halfpacho@gmail.com> * implement PR suggestion from @Panquesito7 Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt
added a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
* updated links to contributing guidelines fix devicons#1328 * implement review suggestions by @Panquesito7 Co-authored-by: David Leal <halfpacho@gmail.com> * implement PR suggestion from @Panquesito7 Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt
added a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
* updated links to contributing guidelines fix devicons#1328 * implement review suggestions by @Panquesito7 Co-authored-by: David Leal <halfpacho@gmail.com> * implement PR suggestion from @Panquesito7 Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1328
Double check these details before you open a PR
Features
This PR closes NONE
Notes
Didn't update link in index.html since it doesn't point to a specific place in CONTRIBUTING.md. For a general overview, the CONTRIBUTING.md file is still the best option imo.