Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated links to contributing guidelines #1333

Merged

Conversation

Snailedlt
Copy link
Collaborator

fix #1328

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

This PR closes NONE

Notes

Didn't update link in index.html since it doesn't point to a specific place in CONTRIBUTING.md. For a general overview, the CONTRIBUTING.md file is still the best option imo.

@Panquesito7 Panquesito7 added the bug Use this label for pointing out bugs label Jul 28, 2022
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thank you! 🚀

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Elegant

@Panquesito7 Panquesito7 merged commit 04be84b into devicons:develop Jul 29, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* updated links to contributing guidelines

fix devicons#1328

* implement review suggestions by @Panquesito7

Co-authored-by: David Leal <halfpacho@gmail.com>

* implement PR suggestion from @Panquesito7

Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* updated links to contributing guidelines

fix devicons#1328

* implement review suggestions by @Panquesito7

Co-authored-by: David Leal <halfpacho@gmail.com>

* implement PR suggestion from @Panquesito7

Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* updated links to contributing guidelines

fix devicons#1328

* implement review suggestions by @Panquesito7

Co-authored-by: David Leal <halfpacho@gmail.com>

* implement PR suggestion from @Panquesito7

Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: David Leal <halfpacho@gmail.com>
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Use this label for pointing out bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants