Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: astro (original, original-wordmark, plain, plain-wordmark) #1350

Merged
merged 9 commits into from
Aug 22, 2022
Merged

Conversation

szmazhr
Copy link
Contributor

@szmazhr szmazhr commented Aug 19, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1034

Link to prove your SVG is correct and up-to-date.

https://astro.build/press/

@Panquesito7 Panquesito7 linked an issue Aug 19, 2022 that may be closed by this pull request
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Aug 19, 2022
@github-actions

This comment was marked as outdated.

@Panquesito7 Panquesito7 changed the title new icon: Astro (original, original-wordmark, plain, plain-wordmark) new icon: astro (original, original-wordmark, plain, plain-wordmark) Aug 19, 2022
@github-actions

This comment was marked as outdated.

@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 20, 2022
@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'astro-original-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'astro-plain-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@szmazhr
Copy link
Contributor Author

szmazhr commented Aug 20, 2022

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'astro-original-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'astro-plain-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot smile

do I need to do something here?

@devicons devicons deleted a comment from github-actions bot Aug 20, 2022
@Panquesito7 Panquesito7 removed the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 20, 2022
@Panquesito7
Copy link
Member

Hi!
I'm the check-bot and we have some issues with your PR:

SVG Error in 'astro-original-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'astro-plain-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help, SVG-Checker Bot smile

do I need to do something here?

Yeah. It would be best if you resize both the original-wordmark and plain-wordmark files. For further information, you should check out our SVG standards and Recommended tools.

Let us know if you need any help. Feel free to hop into our Discord community. 🙂

@szmazhr
Copy link
Contributor Author

szmazhr commented Aug 20, 2022

Yeah. It would be best if you resize both the original-wordmark and plain-wordmark files. For further information, you should check out our SVG standards and Recommended tools.

Let us know if you need any help. Feel free to hop into our Discord community. slightly_smiling_face

ok, I have updated the viewBox to 0 0 128 128

sorry, force-pushed because there was a typo in commit message

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Paths need to be merged for plain icons though. If you want you could try to make some line icons as well, but it's not a requirement, so that's only if you want to :)

icons/astro/astro-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/astro/astro-plain.svg Outdated Show resolved Hide resolved
@szmazhr szmazhr requested a review from Snailedlt August 20, 2022 17:33
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 21, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you for your contribution! 🚀

@Snailedlt Snailedlt requested review from a team and amacado and removed request for a team August 21, 2022 08:09
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 🚀

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Maintainable

@Panquesito7 Panquesito7 merged commit bf81b9b into devicons:develop Aug 22, 2022
@szmazhr szmazhr deleted the astro branch August 22, 2022 07:27
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…evicons#1350)

* bump npm version to v2.15.1

* new icon: Astro

* Fix `plain-wordmark` filename

* Changed viewBox to 0 0 128 128

* Path merged for plain icons

* Removed Unnecessary `<g />`  tag

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Co-authored-by: Amacado <clemens.bastian@gmail.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…evicons#1350)

* bump npm version to v2.15.1

* new icon: Astro

* Fix `plain-wordmark` filename

* Changed viewBox to 0 0 128 128

* Path merged for plain icons

* Removed Unnecessary `<g />`  tag

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Co-authored-by: Amacado <clemens.bastian@gmail.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…evicons#1350)

* bump npm version to v2.15.1

* new icon: Astro

* Fix `plain-wordmark` filename

* Changed viewBox to 0 0 128 128

* Path merged for plain icons

* Removed Unnecessary `<g />`  tag

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Co-authored-by: Amacado <clemens.bastian@gmail.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@lunatic-fox lunatic-fox mentioned this pull request Oct 22, 2022
1 task
@lunatic-fox lunatic-fox mentioned this pull request Jan 31, 2023
1 task
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: Astro
5 participants