-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: astro (original, original-wordmark, plain, plain-wordmark) #1350
Conversation
Fix issue with npm publish script
Build preparation for release v2.15.1
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
do I need to do something here? |
Yeah. It would be best if you resize both the Let us know if you need any help. Feel free to hop into our Discord community. 🙂 |
ok, I have updated the viewBox to 0 0 128 128 sorry, force-pushed because there was a typo in commit message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Paths need to be merged for plain icons though. If you want you could try to make some line icons as well, but it's not a requirement, so that's only if you want to :)
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your contribution! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…evicons#1350) * bump npm version to v2.15.1 * new icon: Astro * Fix `plain-wordmark` filename * Changed viewBox to 0 0 128 128 * Path merged for plain icons * Removed Unnecessary `<g />` tag Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Amacado <clemens.bastian@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com>
…evicons#1350) * bump npm version to v2.15.1 * new icon: Astro * Fix `plain-wordmark` filename * Changed viewBox to 0 0 128 128 * Path merged for plain icons * Removed Unnecessary `<g />` tag Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Amacado <clemens.bastian@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com>
…evicons#1350) * bump npm version to v2.15.1 * new icon: Astro * Fix `plain-wordmark` filename * Changed viewBox to 0 0 128 128 * Path merged for plain icons * Removed Unnecessary `<g />` tag Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Amacado <clemens.bastian@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com>
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1034
Link to prove your SVG is correct and up-to-date.
https://astro.build/press/