Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve contributing deprecation notice #1367

Merged
merged 1 commit into from
Sep 13, 2022
Merged

docs: improve contributing deprecation notice #1367

merged 1 commit into from
Sep 13, 2022

Conversation

Panquesito7
Copy link
Member

Things added/changed:

  • Improve contributing deprecation notice.

Snailedlt
Snailedlt requested changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but for some reason there seems to be an empty change at line 506. Any idea what that is?

CONTRIBUTING.md
| svgviewer.dev | https://www.svgviewer.dev/ | View, save, and optimize SVGs |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a change here. Could you point out what exactly changed on this line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that, but I didn't make any changes there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's maybe the line ending / line break, check https://stackoverflow.com/questions/1552749/difference-between-cr-lf-lf-and-cr-line-break-types

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve once this diff is fixed. Invisible changes always leave me with a bad taste in the mouth

Snailedlt
Snailedlt requested changes Sep 11, 2022
View reviewed changes
CONTRIBUTING.md
| svgviewer.dev | https://www.svgviewer.dev/ | View, save, and optimize SVGs |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve once this diff is fixed. Invisible changes always leave me with a bad taste in the mouth

@Panquesito7
Copy link
Member Author

I found the issue: it seems there was a missing endline in the original file, and on this file, it was automatically added.
That's OK as some IDEs could have issues without an endline. There should be no issues with that. 🙂

@Snailedlt Snailedlt merged commit 87b764f into develop Sep 13, 2022
@Panquesito7 Panquesito7 deleted the update_contributing branch September 13, 2022 14:42
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@Panquesito7 @Snailedlt
docs: improve contributing depreca... (devicons#1367)
11af0dc 
...tion notice.
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@Panquesito7 @Snailedlt
docs: improve contributing depreca... (devicons#1367)
9f9818f 
...tion notice.
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@Panquesito7 @Snailedlt
docs: improve contributing depreca... (devicons#1367)
c8f4c49 
...tion notice.
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenSouchet BenSouchet BenSouchet left review comments

@Snailedlt Snailedlt Snailedlt approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Panquesito7 @BenSouchet @Snailedlt