Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: vala (original, plain, plain-wordmark) #1397

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

lunatic-fox
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1360

Link to prove your SVG is correct and up-to-date.

https://vala.dev/
https://raw.githubusercontent.com/github/explore/f2320762bfd30d076b43d8c0d61be9fba3f85ca4/topics/vala/vala.png

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons you have look good, but can you also add one for vala-original-wordmark?
Should be same as vala-plain-wordmark, but with the same background as vala-original

@lunatic-fox
Copy link
Contributor Author

lunatic-fox commented Oct 1, 2022

On Vala's website they're using the base SVG to make plain-wordmark version in white and solid purple background:
on-site

Vala's logo is a styled "V" in a linear light purple to purple gradient background:
original-wordmark

The problem is that logo has some shadows in dark purple shades:
original-wordmark-detail

So vala-original-wordmark version can be:
1. a white text with a solid purple background
2. a white text with a linear gradient background in shades of purple
3. a white text with some shadows, like the logo, and a linear gradient background in shades of purple

The first option seems more right to me, even the second one looking more beautiful:
proposal

That said I want your opinion about which way should I go on this one.
Thanks!

@Snailedlt
Copy link
Collaborator

@lunatic-fox
I think the more similar to the vala-original icon, the better. Since that fits better with their original brand.

So I guess option 3 (or maybe 2)? I'm not sure, but would also like more opinions on this.

@BenSouchet @Panquesito7 what do you think of @lunatic-fox 's suggestions above, any preferences?

@Snailedlt Snailedlt added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection awaiting triage Awaiting triage from a maintainer labels Oct 1, 2022
@Panquesito7
Copy link
Member

Option 3 seems the best to me. It looks nice.

@BenSouchet
Copy link
Contributor

Yes Option 2 or 3 is good and stick with the brand identity 👍

@Snailedlt
Copy link
Collaborator

Well then, looks like you have your answer @lunatic-fox :)

@lunatic-fox
Copy link
Contributor Author

Yeah @Snailedlt. Option 3 wins.
Thank you guys! I'll do as soon as possible.

@lunatic-fox
Copy link
Contributor Author

original-wordmark version added!

Snailedlt
Snailedlt previously approved these changes Oct 4, 2022
@Snailedlt
Copy link
Collaborator

@lunatic-fox Approved, but you'll need to fix the conflict before merging, and I guess I'll have to approve again after that :)

@lunatic-fox
Copy link
Contributor Author

Solved it: vala object was overlapping vercel object in devicon.json, because the branch add_vala wasn't updated I think.

I got a little bit concerned about this commit title: Merge branch 'develop' into add_vala, and I was like: Oh "well", I did something wrong, but now I think I got the idea it was just an update to add_vala branch.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! ✔️

Thank you for the contribution 🙇

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed awaiting triage Awaiting triage from a maintainer labels Oct 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Snailedlt Snailedlt merged commit 3fabc97 into devicons:develop Oct 4, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@lunatic-fox lunatic-fox deleted the add_vala branch June 1, 2023 12:28
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants