-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: okta (original, original-wordmark, plain, plain-wordmark) #1427
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: David Leal <halfpacho@gmail.com>
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weh Isn't okta a company, and not a product?
From looking at their website I think the company is called okta, and they have multiple products:
If this is the case, okta
is out of scope for devicons
ref: What Icons Do We Accept?
Hmm, i think i saw Okta as Auth provider Service. |
Agreed, we should definitely do that. In fact I did go through all the old issues a while back and triaged a few of them. As you can imagine though, it takes a long time to look through all of them thoroughly when there are 200+ issues, so many of them were just glanced over. Sadly we are too few (2) active maintainers atm, so we prioritize PRs and automation issues over all else. All that said, I'm not convinced on adding or not adding this icon yet, so please do make some arguments for/against adding it :) Edit: |
@Panquesito7 Could you also take another look at this, considering the things said by me and weh above? |
In my opinion, this is a special case, but I think this PR should be accepted since is related to "okta Developer" icons and referencing "okta Developer" in |
Well, I did a bit more research... and I couldn't find any logos for their products. Their product names are really generic too, and aren't really product names, but just descriptions of whta the products do. So it looks like they're kinda marketing okta as a platform and not a company logo... in which case I would put it in the same category as Amazon Web Services, which means it's eligible. I'll remove the awaiting triage label then, so it's ready for review :) |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
I made a commit to unify the paths for the plain versions, so that it complies with our SVG-Standards.
Thank you for your contribution, and your patience!
It's always a pleasure to review your PR's @weh 💯
I'll just merge this right away since a previous version was approved by @Panquesito7 :) |
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes NONE
closes #171
Link to prove your SVG is correct and up-to-date.
https://www.okta.com/press-room/media-assets/developer/