Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: okta (original, original-wordmark, plain, plain-wordmark) #1427

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

weh
Copy link
Contributor

@weh weh commented Oct 4, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE
closes #171

Link to prove your SVG is correct and up-to-date.

https://www.okta.com/press-room/media-assets/developer/

@github-actions

This comment was marked as outdated.

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 4, 2022
devicon.json Outdated Show resolved Hide resolved
Co-authored-by: David Leal <halfpacho@gmail.com>
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 11, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Panquesito7
Panquesito7 previously approved these changes Oct 11, 2022
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks! 🚀

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weh Isn't okta a company, and not a product?
From looking at their website I think the company is called okta, and they have multiple products:
image

If this is the case, okta is out of scope for devicons
ref: What Icons Do We Accept?

@weh
Copy link
Contributor Author

weh commented Oct 14, 2022

Hmm, i think i saw Okta as Auth provider Service.
But if you do not want those Icons, you should IMHO triage the Icon requests, before the work is done and the MR exists. I was especially looking for older Issues, that exist for a longer time, not the newest ones in the list.
Maybe you should clarify the triage process and add some kind of label, that clearly shows that this icon is going to be accepted, or close the open Issue.

@Snailedlt
Copy link
Collaborator

Snailedlt commented Oct 14, 2022

Agreed, we should definitely do that. In fact I did go through all the old issues a while back and triaged a few of them. As you can imagine though, it takes a long time to look through all of them thoroughly when there are 200+ issues, so many of them were just glanced over.

Sadly we are too few (2) active maintainers atm, so we prioritize PRs and automation issues over all else.

All that said, I'm not convinced on adding or not adding this icon yet, so please do make some arguments for/against adding it :)

Edit:
Since we are in need of more maintainers, please feel free to apply for maintainer if you'd like: #1436

@Snailedlt Snailedlt added the awaiting triage Awaiting triage from a maintainer label Oct 14, 2022
@Snailedlt
Copy link
Collaborator

@Panquesito7 Could you also take another look at this, considering the things said by me and weh above?

@lunatic-fox
Copy link
Contributor

In my opinion, this is a special case, but I think this PR should be accepted since is related to "okta Developer" icons and referencing "okta Developer" in altnames. Alternatively we can swap the name by its altname. 🤔
Maybe I'm wrong, but as far as I see, "okta Developer" is some kind of authentication integration platform.

@Snailedlt
Copy link
Collaborator

Well, I did a bit more research... and I couldn't find any logos for their products. Their product names are really generic too, and aren't really product names, but just descriptions of whta the products do. So it looks like they're kinda marketing okta as a platform and not a company logo... in which case I would put it in the same category as Amazon Web Services, which means it's eligible.

I'll remove the awaiting triage label then, so it's ready for review :)
Thanks for your patience @weh .
And thanks for your input @lunatic-fox :)

@Snailedlt Snailedlt removed the awaiting triage Awaiting triage from a maintainer label Nov 7, 2022
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Nov 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

I made a commit to unify the paths for the plain versions, so that it complies with our SVG-Standards.

Thank you for your contribution, and your patience!
It's always a pleasure to review your PR's @weh 💯

@Snailedlt
Copy link
Collaborator

I'll just merge this right away since a previous version was approved by @Panquesito7 :)

@Snailedlt Snailedlt merged commit 2fa2d08 into devicons:develop Nov 7, 2022
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants