Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: qwik (original, plain, original-wordmark, plain-wordmark) #1435

Merged
merged 5 commits into from
Oct 11, 2022
Merged

new icon: qwik (original, plain, original-wordmark, plain-wordmark) #1435

merged 5 commits into from
Oct 11, 2022

Conversation

AmreshSinha
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1409

Link to prove your SVG is correct and up-to-date.

https://qwik.builder.io/media/

Snailedlt
Snailedlt requested changes Oct 9, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons look good, so just a few standards that need to be followed, and we're good :)

icons/qwik/qwik-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/qwik/qwik-plain.svg Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
@AmreshSinha
Copy link
Contributor Author

AmreshSinha commented Oct 9, 2022 •
edited
Loading

The icons look good, so just a few standards that need to be followed, and we're good :)

Yep done! Have a look. Also, this is my time contributing to Devicons. 😃
Also, should I remove the grouping or keep it there?

@Snailedlt Snailedlt added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 9, 2022
@Snailedlt
Copy link
Collaborator

The icons look good, so just a few standards that need to be followed, and we're good :)

Yep done! Have a look. Also, this is my time contributing to Devicons. smiley Also, should I remove the grouping or keep it there?

@AmreshSinha
Nice!
Very well done for your first contribution!
Also, what do you mean by grouping?

@github-actions

This comment was marked as outdated.

Sign in to view
@AmreshSinha
Copy link
Contributor Author

The icons look good, so just a few standards that need to be followed, and we're good :)

Yep done! Have a look. Also, this is my time contributing to Devicons. smiley Also, should I remove the grouping or keep it there?

@AmreshSinha Nice! Very well done for your first contribution! Also, what do you mean by grouping?

by grouping, I mean that g element inside svg

@Snailedlt
Copy link
Collaborator

@AmreshSinha
Ahh, okey :)
I guess the g elements can be removed

@AmreshSinha
Copy link
Contributor Author

Done, Removed g element. 👍
Can you test it again and check if it's fine or has any breaking changes?

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Snailedlt
Copy link
Collaborator

Looks good, ship it! 😁

Snailedlt
Snailedlt previously approved these changes Oct 9, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thanks for another great contribution! 💯

@Snailedlt Snailedlt requested review from a team, amacado and Panquesito7 and removed request for a team October 9, 2022 18:20
Panquesito7
Panquesito7 reviewed Oct 11, 2022
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks. 🚀

@Panquesito7 Panquesito7 merged commit b9e01e1 into devicons:develop Oct 11, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@AmreshSinha @Panquesito7 @Snailedlt
new icon: qwik (original, plain, original-wordmark, plain-wordmark) (d…
d5c511d 
…evicons#1435)

* Add qwik icons

* Fix order of qwik

* Fix issues
- devicons#1435 (review)

* Remove g SVG element

* Apply suggestions from code review

Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@AmreshSinha @Panquesito7 @Snailedlt
new icon: qwik (original, plain, original-wordmark, plain-wordmark) (d…
f516c30 
…evicons#1435)

* Add qwik icons

* Fix order of qwik

* Fix issues
- devicons#1435 (review)

* Remove g SVG element

* Apply suggestions from code review

Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@AmreshSinha @Panquesito7 @Snailedlt
new icon: qwik (original, plain, original-wordmark, plain-wordmark) (d…
898bea2 
…evicons#1435)

* Add qwik icons

* Fix order of qwik

* Fix issues
- devicons#1435 (review)

* Remove g SVG element

* Apply suggestions from code review

Co-authored-by: David Leal <halfpacho@gmail.com>
@sinuheshinbr sinuheshinbr mentioned this pull request May 3, 2023
Closed
1 task
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@Snailedlt Snailedlt Snailedlt left review comments

@amacado amacado Awaiting requested review from amacado

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmreshSinha @Snailedlt @Panquesito7