-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: swagger (original, original-wordmark, plain, plain-wordmark) #1561
Conversation
@yeyeto2788, I think it would be a good idea to separate icon from its wordmark version and call it the swagger-originalswagger-original-wordmarkswagger-plainswagger-plain-wordmark |
Co-authored-by: Red Panther <41539361+PantheraRed@users.noreply.github.com>
@PantheraRed that is fine for me but then the original wouldn't be the original as the real one has the wording on it. I regards of your versions, they do look great considering that I was using the blueish color as the predominant one but definitely the green one pops a lot. @Snailedlt, if you still want me to change and agree with @PantheraRed it just let me know. Best. |
Hello there! The main color of this icon is
The If you choose the icons with
|
@yeyeto2788 I agree with what @PantheraRed and @lunatic-fox suggested, so go ahead 😊 |
All the SVGs in this #1561 (comment) are already optimized and don't have |
I was talking based on @yeyeto2788 icons, but that's great, since the icons that you made are just ready-to-go. 🤩 |
Hey guys! Sorry for the delay. Changes applied, thanks @PantheraRed for providing the icons and @Snailedlt and @lunatic-fox for your quick reply. |
- Fix `devicon.json` structure based on `39f6d077c383cc63339387409622ca73b8d1eb63` commit - Resize the icons to fit the view box
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some commits to fix the devicon.json
structure and a little resize to the icons.
@yeyeto2788, I think you should check out for some linter on the IDE that you're using to edit devicon.json
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! ✔
Thank you for this contribution! 🚀
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #903
Link to prove your SVG is correct and up-to-date.