Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: swagger (original, original-wordmark, plain, plain-wordmark) #1561

Merged
merged 8 commits into from
Dec 6, 2022

Conversation

yeyeto2788
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #903

Link to prove your SVG is correct and up-to-date.

@yeyeto2788 yeyeto2788 changed the base branch from master to develop December 1, 2022 06:32
@yeyeto2788 yeyeto2788 changed the title new icon: <i>Iswagger</i> (<i>original, plain</i>) new icon: swagger (original, plain) Dec 1, 2022
devicon.json Outdated Show resolved Hide resolved
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Dec 1, 2022
@PantheraRed
Copy link
Contributor

@yeyeto2788, I think it would be a good idea to separate icon from its wordmark version and call it the original version. Also fonts made out of original and plain versions are very small and multi-colored. I have made a few changes and new versions. Please have a look and give your opinion on them.

swagger-original

swagger-original

swagger-original-wordmark

swagger-original-wordmark

swagger-plain

swagger-plain

swagger-plain-wordmark

swagger-plain-wordmark

Co-authored-by: Red Panther <41539361+PantheraRed@users.noreply.github.com>
@yeyeto2788
Copy link
Contributor Author

@PantheraRed that is fine for me but then the original wouldn't be the original as the real one has the wording on it.

I regards of your versions, they do look great considering that I was using the blueish color as the predominant one but definitely the green one pops a lot.

@Snailedlt, if you still want me to change and agree with @PantheraRed it just let me know.

Best.

@lunatic-fox
Copy link
Contributor

Hello there!

The main color of this icon is #173647 and I agree with @PantheraRed in original and original-wordmark versions.

plain and plain-wordmark versions can be done from the current plain version, but I prefer the idea of @PantheraRed since variations of this color #85ea2d are more frequent than variations of #173647 on their website, suggesting that it should be the main theme color related to this technology.

The original version is fine since they're using it as favicon and if you look at the bottom of their website they're also using this version of the icon. And original-wordmark is similar to original version, but with the technology name.

If you choose the icons with #85ea2d color, remember to change color property before make the new commit. We also have to remove the <clipPath> from plain and plain-wordmark*.

* To be done.


💡 General tip

plain, plain-wordmark, line and line-versions don't really need a fill color, as long as those versions receive the fill color from devicon.json color property. The only exception happens when some version is an alias from original or original-wordmark versions.

@Snailedlt
Copy link
Collaborator

@yeyeto2788 I agree with what @PantheraRed and @lunatic-fox suggested, so go ahead 😊

@PantheraRed
Copy link
Contributor

@lunatic-fox,

If you choose the icons with #85ea2d color, remember to change color property before make the new commit. We also have to remove the <clipPath> from plain and plain-wordmark*.

All the SVGs in this #1561 (comment) are already optimized and don't have <clipPath> attributes.

@lunatic-fox
Copy link
Contributor

@lunatic-fox,

If you choose the icons with #85ea2d color, remember to change color property before make the new commit. We also have to remove the <clipPath> from plain and plain-wordmark*.

All the SVGs in this #1561 (comment) are already optimized and don't have <clipPath> attributes.

I was talking based on @yeyeto2788 icons, but that's great, since the icons that you made are just ready-to-go. 🤩

@yeyeto2788
Copy link
Contributor Author

Hey guys! Sorry for the delay.

Changes applied, thanks @PantheraRed for providing the icons and @Snailedlt and @lunatic-fox for your quick reply.

@lunatic-fox lunatic-fox changed the title new icon: swagger (original, plain) new icon: swagger (original, original-wordmark, plain, plain-wordmark) Dec 5, 2022
- Fix `devicon.json` structure based on `39f6d077c383cc63339387409622ca73b8d1eb63` commit

- Resize the icons to fit the view box
@lunatic-fox lunatic-fox added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

devicon.json Outdated Show resolved Hide resolved
@lunatic-fox lunatic-fox added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some commits to fix the devicon.json structure and a little resize to the icons.

@yeyeto2788, I think you should check out for some linter on the IDE that you're using to edit devicon.json

devicon.json Outdated Show resolved Hide resolved
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! ✔
Thank you for this contribution! 🚀

@Snailedlt Snailedlt merged commit 77ff589 into devicons:develop Dec 6, 2022
@yeyeto2788 yeyeto2788 deleted the swagger branch March 7, 2023 09:04
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Request: Swagger
4 participants