Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: pnpm (original, original-wordmark, plain, plain-wordmark) #1666

Merged
merged 15 commits into from
Apr 24, 2023

Conversation

felipe-heredia
Copy link
Contributor

Double-check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1068

Link to prove your SVG is correct and up-to-date.

PNPM Logos

Note: I just added the original without a wordmark because the width of 128 cannot work perfectly and it is my first PR, so I don't know how to do that. If someone can help me, I can add the wordmark.

@felipe-heredia felipe-heredia changed the title new icon: pnpm (original, plain) new icon: pnpm (original, original-wordark) Feb 4, 2023
@felipe-heredia felipe-heredia changed the title new icon: pnpm (original, original-wordark) new icon: pnpm (original, original-wordmark) Feb 4, 2023
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Feb 7, 2023
@Panquesito7 Panquesito7 linked an issue Feb 7, 2023 that may be closed by this pull request
@Panquesito7
Copy link
Member

Hmm. I'm not sure if there's a way to use the official wordmark logo with 128x128 size.
@devicons/supporter, thoughts on this?

@Snailedlt
Copy link
Collaborator

@Panquesito7 Can't we just remove the height and width attributes and resize it using the tools explained in our "Recommended resources and tools" wiki page?

@lunatic-fox lunatic-fox changed the title new icon: pnpm (original, original-wordmark) new icon: pnpm (original, original-wordmark, plain, plain-wordmark) Mar 6, 2023
icons/pnpm/pnpm-plain.svg Outdated Show resolved Hide resolved
icons/pnpm/pnpm-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/pnpm/pnpm-original.svg Outdated Show resolved Hide resolved
icons/pnpm/pnpm-original-wordmark.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
felipe-heredia and others added 5 commits March 8, 2023 08:31
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting there 🚀
Now we just need to:

  • resize and center pnpm-original-wordmark.svg
  • center and unite paths for pnpm-plain-wordmark.svg
  • unite paths for pnpm-plain.svg

icons/pnpm/pnpm-plain-wordmark.svg Show resolved Hide resolved
icons/pnpm/pnpm-original.svg Show resolved Hide resolved
icons/pnpm/pnpm-plain.svg Outdated Show resolved Hide resolved
icons/pnpm/pnpm-original-wordmark.svg Show resolved Hide resolved
@lunatic-fox lunatic-fox added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Mar 23, 2023
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Panquesito7
Panquesito7 previously approved these changes Apr 9, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks. 🚀

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job so far. Only thing left to fix now is the unrelated changes in devicon.json (see comments below) :)

devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! ✔️
Thank you @felipesuri for the contribution, and thank you @lunatic-fox for the quick fix 💯

@Snailedlt Snailedlt merged commit 421a703 into devicons:develop Apr 24, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: PNPM
4 participants