-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: pnpm (original, original-wordmark, plain, plain-wordmark) #1666
Conversation
Hmm. I'm not sure if there's a way to use the official wordmark logo with 128x128 size. |
@Panquesito7 Can't we just remove the height and width attributes and resize it using the tools explained in our "Recommended resources and tools" wiki page? |
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting there 🚀
Now we just need to:
- resize and center
pnpm-original-wordmark.svg
- center and unite paths for
pnpm-plain-wordmark.svg
- unite paths for
pnpm-plain.svg
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job so far. Only thing left to fix now is the unrelated changes in devicon.json (see comments below) :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! ✔️
Thank you @felipesuri for the contribution, and thank you @lunatic-fox for the quick fix 💯
Double-check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1068
Link to prove your SVG is correct and up-to-date.
PNPM Logos
Note: I just added the original without a wordmark because the width of 128 cannot work perfectly and it is my first PR, so I don't know how to do that. If someone can help me, I can add the wordmark.