Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token error #1671

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Fix token error #1671

merged 1 commit into from
Feb 9, 2023

Conversation

Panquesito7
Copy link
Member

Things added/changed:

  • Fix token error.
    • This should fix the error with the Build Icons workflow. The way the token's being accessed in Windows and Ubuntu changes, which caused the error. Should be reviewed/merged ASAP.

@Panquesito7 Panquesito7 added bug Use this label for pointing out bugs devops Use this label for devops related enhancements labels Feb 8, 2023
@Panquesito7
Copy link
Member Author

Will be merging this and testing it. If it doesn't work, I'll revert the changes.

@Panquesito7 Panquesito7 merged commit 990d60a into draft-release Feb 9, 2023
@Panquesito7 Panquesito7 deleted the fix_token branch February 9, 2023 00:46
@Snailedlt
Copy link
Collaborator

@Panquesito7 Any updates? Did it work?

@Panquesito7
Copy link
Member Author

@Panquesito7 Any updates? Did it work?

Yep, it worked! #1673.
We just need to merge #1668 in order to fix the GulpFile and also make other improvements.

@Panquesito7 Panquesito7 mentioned this pull request Feb 9, 2023
Merged
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox

Assignees
No one assigned
Labels
bug Use this label for pointing out bugs devops Use this label for devops related enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Panquesito7 @Snailedlt