Update many of the actions to their latest version #1731
Conversation
| @@ -5,7 +5,7 @@ on: | |||
|
|
|||
| jobs: | |||
| stale: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-latestlatest | |||
There was a problem hiding this comment.
| runs-on: ubuntu-latestlatest | |
| runs-on: ubuntu-latest |
|
I've tested a few workflows on my fork and they seem to be working fine. |
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
There was a problem hiding this comment.
Statically it looks good, and I trust you tested all of the workflows properly :)
Thanks for the contributions @Panquesito7 🙇
Thank you for reviewing! In case there's anything wrong, we can always revert this PR. 😉 |
There was a problem hiding this comment.
Great work! 🚀
Just one suggestion about dawidd6/action-download-artifact action version and @Snailedlt suggestion on .github/drafts/stale.yml.
| @@ -20,22 +20,22 @@ jobs: | |||
| run: echo $PEEK_STATUS | |||
|
|
|||
| - name: Download workflow artifact | |||
| uses: dawidd6/action-download-artifact@v2.11.0 | |||
| uses: dawidd6/action-download-artifact@v2.26.1 | |||
There was a problem hiding this comment.
There is a recently update to that action.
| uses: dawidd6/action-download-artifact@v2.26.1 | |
| uses: dawidd6/action-download-artifact@v2.27.0 |
| steps: | ||
| - name: Check if the trigger run worked. If it failed, fail the current run. | ||
| if: github.event.workflow_run.conclusion != 'success' | ||
| uses: cutenode/action-always-fail@v1.0.1 | ||
|
|
||
| - name: Download workflow artifact | ||
| uses: dawidd6/action-download-artifact@v2.11.0 | ||
| uses: dawidd6/action-download-artifact@v2.26.1 |
There was a problem hiding this comment.
| uses: dawidd6/action-download-artifact@v2.26.1 | |
| uses: dawidd6/action-download-artifact@v2.27.0 |
|
Weird, GitHub did not notify me about the reviews 👀 let me update those. Thanks, @lunatic-fox. 🙂 |
| @@ -7,7 +7,7 @@ on: | |||
| jobs: | |||
| post_screenshots_in_comment: | |||
| name: Post the screenshot | |||
| runs-on: ubuntu-18.04 | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
⚠ This change will take effect when this commit is merged to master, as for now this action will be loading indefinitely to find a ubuntu-18.04 machine.
Things added/changed: