Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: reactnavigation (original) #1807

Merged
merged 4 commits into from
Jul 4, 2023
Merged

new icon: reactnavigation (original) #1807

merged 4 commits into from
Jul 4, 2023

Conversation

Gautam25Raj
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1803

Link to prove your SVG is correct and up-to-date.

https://reactnavigation.org/

Gautam25Raj and others added 2 commits June 24, 2023 00:05
@Gautam25Raj
new icon: reactnavigation (original, plain)
b268af0
@lunatic-fox
- Add alias to original version
f918784 
- Remove `plain` version
- Convert stroke to path and simplify `original`
@lunatic-fox lunatic-fox changed the title new icon: reactnavigation (original, plain) new icon: reactnavigation (original) Jun 28, 2023
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 4, 2023
Panquesito7
Panquesito7 reviewed Jul 4, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
Gautam25Raj
Gautam25Raj commented Jul 4, 2023
View reviewed changes
Copy link
Contributor Author

@Gautam25Raj Gautam25Raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated devicon.json

Panquesito7
Panquesito7 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you. 🚀

image

lunatic-fox
lunatic-fox approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! ✔️
Thank you for this contribution! 🚀

@lunatic-fox lunatic-fox merged commit a83e677 into devicons:develop Jul 4, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gautam25Raj @Panquesito7 @lunatic-fox