Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: spack (original, plain) #1813

Merged
merged 3 commits into from
Oct 21, 2023
Merged

new icon: spack (original, plain) #1813

merged 3 commits into from
Oct 21, 2023

Conversation

dennisklein
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date

Gautam25Raj
Gautam25Raj suggested changes Jun 28, 2023
View reviewed changes
icons/spack/spack-original.svg Outdated Show resolved Hide resolved
icons/spack/spack-plain.svg Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 4, 2023
Panquesito7
Panquesito7 reviewed Jul 4, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 🚀

image

image

Snailedlt
Snailedlt approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for a great contribution! 🚀

@Snailedlt Snailedlt merged commit 5fb38fd into devicons:develop Oct 21, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gautam25Raj Gautam25Raj Gautam25Raj requested changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@Snailedlt Snailedlt Snailedlt approved these changes

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dennisklein @Snailedlt @Panquesito7 @Gautam25Raj @lunatic-fox