Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: replit (original, original-wordmark, plain-wordmark) #1919

Merged
merged 10 commits into from
Oct 22, 2023
Merged

new icon: replit (original, original-wordmark, plain-wordmark) #1919

merged 10 commits into from
Oct 22, 2023

Conversation

Gautam25Raj
Copy link
Contributor

@Gautam25Raj Gautam25Raj commented Oct 21, 2023 •
edited by Snailedlt
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1857

Link to prove your SVG is correct and up-to-date.

Official Logo Source: https://replit.com/brandkit
website: https://replit.com/

Snailedlt
Snailedlt requested changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Overall it looks pretty good. I suggested some changes, once those are fixed it should be good :)

icons/replit/replit-original.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
icons/replit/replit-original-wordmark.svg Outdated Show resolved Hide resolved
Gautam25Raj and others added 3 commits October 22, 2023 15:33
@Gautam25Raj
Update icons
1941ad3
@Gautam25Raj @Snailedlt
Update devicon.json
730209e 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Gautam25Raj
Update devicon.json
0bf2503
Gautam25Raj
Gautam25Raj commented Oct 22, 2023
View reviewed changes
Copy link
Contributor Author

@Gautam25Raj Gautam25Raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update .json file

Gautam25Raj
Gautam25Raj commented Oct 22, 2023
View reviewed changes
Copy link
Contributor Author

@Gautam25Raj Gautam25Raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess now they look perfectly fine

Snailedlt
Snailedlt requested changes Oct 22, 2023
View reviewed changes
icons/replit/replit-plain.svg Outdated Show resolved Hide resolved
@Gautam25Raj Gautam25Raj changed the title new icon: replit (original) new icon: replit (original, original-wordmark, plain-wordmark) Oct 22, 2023
Snailedlt
Snailedlt reviewed Oct 22, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
Snailedlt
Snailedlt approved these changes Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for another great contribution! 💯 🙇

@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 22, 2023
@Snailedlt Snailedlt requested review from a team, ConX, canaleal and lunatic-fox and removed request for a team October 22, 2023 10:28
ConX
ConX approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@ConX ConX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! Thanks @Gautam25Raj!

@Snailedlt Snailedlt merged commit 7c37675 into devicons:develop Oct 22, 2023
5 checks passed
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@ConX ConX ConX approved these changes

@canaleal canaleal Awaiting requested review from canaleal

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gautam25Raj @ConX @Snailedlt