new icon: blazor (original, plain, line) #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canaleal
previously approved these changes
Oct 23, 2023
canaleal
added
the
hacktoberfest-accepted
|
thx @canaleal i updated the PR with the official SVG |
Snailedlt
previously approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Looks good ✅
Thank you for another awesome contribution! You're on fire this month!
No complaints really, but I wanna challenge you a bit @weh.
Would you be willing to create a line version also for this icon?
Tutorial can be found here: #1306 (comment)
Snailedlt
added
the
feature:icon
lunatic-fox
reviewed
Nov 3, 2023
weh
force-pushed
the
feature/619-add-blazor-icon
branch
from
1cab775
to
b749586
Compare
weh
changed the title
|
i added the line version (thank you @lunatic-fox) and rebased the branch to current develop. |
Snailedlt
approved these changes
Nov 25, 2023
Snailedlt
requested review from
a team and
ConX
and removed request for
a team
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes
closes #619
Link to prove your SVG is correct and up-to-date.
https://github.com/dotnet-foundation/swag/blob/4f2805b5f56c10584a74055b9c1c688572ada023/blazor/Blazor_nohalo_16x.svg