Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: crystal (original, original-wordmark, line, line-wordmark) #1992

Merged
merged 4 commits into from
Nov 12, 2023

Conversation

canaleal
Copy link
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to issues in #1977

Link to prove your SVG is correct and up-to-date.

The Crystal original logos are simple enough to be used as the plain versions. Note that the triangle inside the crystal hexagon is clipped out. The color of all the SVGs are black.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the icons look good from a technical standpoint, however the vertical wordmark ("logo stacked" in the image below) version should be chosen over then horizontal one here, since it fills more of the square viewbox, and thus will be easier to read at smaller sizes.

image

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 11, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now, great job on the PR @canaleal ✅ 🚀
image
image
image
image
image

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect again! 💯
Thank you for this contribution! 🚀

@lunatic-fox lunatic-fox merged commit e459e5d into devicons:develop Nov 12, 2023
9 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants