Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update icon: gatsby (original, original-wordmark, plain-wordmark) #2006

Merged
merged 5 commits into from
Nov 25, 2023
Merged

update icon: gatsby (original, original-wordmark, plain-wordmark) #2006

merged 5 commits into from
Nov 25, 2023

Conversation

weh
Copy link
Contributor

@weh weh commented Nov 15, 2023 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

  • Replace gatsby plain by alias
  • Add newlines

This PR closes NONE

related to #2001

Notes

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team November 15, 2023 15:49
@weh weh mentioned this pull request Nov 15, 2023
Closed
9 tasks
@weh weh changed the title Replace plain by alias update icon: gatsby (original, original-wordmark, plain-wordmark) Nov 15, 2023
@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 18, 2023
@Snailedlt Snailedlt mentioned this pull request Nov 19, 2023
Closed
Snailedlt
Snailedlt approved these changes Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for another great contribution! 💯
image
image
image

Snailedlt
Snailedlt requested changes Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, upon closer inspection it looks like there's a bit of padding on the sides (left and right) of the wordmark versions:
image
image

This padding should be removed. Other than that everything looks perfect!

@weh
Copy link
Contributor Author

weh commented Nov 20, 2023

removed padding, and rebased to current develop branch

@weh weh requested a review from Snailedlt November 20, 2023 10:52
Snailedlt
Snailedlt requested changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Now we just need to re-optimize the icons (see my suggestions), and we're good to go! 🚀

icons/gatsby/gatsby-original-wordmark.svg Outdated Show resolved Hide resolved
icons/gatsby/gatsby-plain-wordmark.svg Outdated Show resolved Hide resolved
@weh weh requested a review from Snailedlt November 22, 2023 14:05
lunatic-fox
lunatic-fox approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍🏼
Thank you for this contribution! 🚀

@Snailedlt Snailedlt merged commit 8e94fcb into devicons:develop Nov 25, 2023
5 checks passed
@lunatic-fox lunatic-fox mentioned this pull request Jan 10, 2024
Merged
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@Snailedlt Snailedlt Snailedlt approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@canaleal canaleal Awaiting requested review from canaleal canaleal was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weh @Snailedlt @lunatic-fox @canaleal