Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: nodejs (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2011

Merged
merged 5 commits into from
Dec 17, 2023

Conversation

weh
Copy link
Contributor

@weh weh commented Nov 16, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

  • Replace plain version with alias
  • Remove padding
  • Add newlines

This PR closes NONE

Part of #2001

Notes

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team November 16, 2023 12:41
@weh weh mentioned this pull request Nov 16, 2023
9 tasks
canaleal
canaleal previously approved these changes Nov 17, 2023
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, nice work.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 18, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logos look good, but unfortunately they are outdated. The new logos look like this:
image

https://nodejs.org/static/documents/foundation-visual-guidelines.pdf

@weh
Copy link
Contributor Author

weh commented Nov 22, 2023

So it looks like the old nodejs-original.svg is also not allowed anymore if i understand the guideline correctly.
there is no image only showing the "js" part.

@lunatic-fox
Copy link
Contributor

So it looks like the old nodejs-original.svg is also not allowed anymore if i understand the guideline correctly. there is no image only showing the "js" part.

I think that's it @weh.
What they call PRIMARY LOGO is the original-wordmark version and PRIMARY ICON + PATTERN is the original version.

@lunatic-fox lunatic-fox changed the title update icon: nodejs (original, original-wordmark, plain-wordmark) update icon: nodejs (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) Dec 10, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lunatic-fox Could you also take a look at these suggestions? :)

icons/nodejs/nodejs-line.svg Outdated Show resolved Hide resolved
icons/nodejs/nodejs-plain.svg Outdated Show resolved Hide resolved
icons/nodejs/nodejs-plain-wordmark.svg Outdated Show resolved Hide resolved
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code and the icons looks great!
Thank you @weh and @lunatic-fox for another awesome PR! 🚀
image
image
image
image
image

@Snailedlt
Copy link
Collaborator

Since this PR was made by two people (therefore effectively reviewed by one of them) I'll merge this PR with only my approval :)

@Snailedlt Snailedlt merged commit add8888 into devicons:develop Dec 17, 2023
4 checks passed
@weh
Copy link
Contributor Author

weh commented Dec 18, 2023

awesome, thank you @Snailedlt
had some struggles with this one, and postponed it 😀

@Snailedlt
Copy link
Collaborator

@weh yeah this was a surprisingly difficult one! Don't hesitate to ask for help next time though :)

@weh
Copy link
Contributor Author

weh commented Dec 18, 2023

sure, was still deciding, if i want to try it again ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants