-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icon: nodejs (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, nice work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logos look good, but unfortunately they are outdated. The new logos look like this:
https://nodejs.org/static/documents/foundation-visual-guidelines.pdf
So it looks like the old nodejs-original.svg is also not allowed anymore if i understand the guideline correctly. |
I think that's it @weh. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lunatic-fox Could you also take a look at these suggestions? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code and the icons looks great!
Thank you @weh and @lunatic-fox for another awesome PR! 🚀
Since this PR was made by two people (therefore effectively reviewed by one of them) I'll merge this PR with only my approval :) |
awesome, thank you @Snailedlt |
@weh yeah this was a surprisingly difficult one! Don't hesitate to ask for help next time though :) |
sure, was still deciding, if i want to try it again ;) |
Double check these details before you open a PR
Features
This PR closes NONE
Part of #2001
Notes