-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icon: postcss (original, original-wordmark, plain-wordmark) #2012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, LGTM!
By the way, I added a fill to plain-wordmark path to ensure it follows the same format as the other SVGs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@canaleal sorry, i think i flushed your changes with my force push, can you please check again |
@weh Although I love rebasing myself it's not really that useful in devicons, but it can sometimes be hurtful. Also we don't really care about a clean git history on feature branches since they are squash-merged into develop anyways, so it always ends up being just 1 commit :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, the artifacts are fixed! Excellent work!
However, like you said there are some changes that @canaleal suggested that are missing. I made some new suggestions to hopefully fix those :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another great work! 👍🏼
Thank you for this contribution! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Looks Great! 💯 Thank you for another great PR! 🙇♂️
Double check these details before you open a PR
Features
This PR closes NONE
Part of #2001
Notes