Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update icon: r (original, plain, line) #2021

Merged
merged 5 commits into from
Dec 3, 2023
Merged

update icon: r (original, plain, line) #2021

merged 5 commits into from
Dec 3, 2023

Conversation

canaleal
Copy link
Member

@canaleal canaleal commented Nov 19, 2023 •
edited by Snailedlt
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

Optimized the SVGs and created a line SVG.
Updated the color to #000000 as the old color was randomly picked from the original SVG.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 19, 2023
@Snailedlt Snailedlt mentioned this pull request Nov 19, 2023
Closed
Snailedlt
Snailedlt reviewed Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure about picking black as the main color, imo it should be one of the blues used in the main logo, or on their website. What do you think?

Preview:
image
image
image

icons/r/r-line.svg Outdated Show resolved Hide resolved
@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt and lunatic-fox and removed request for a team November 19, 2023 22:57
Snailedlt
Snailedlt reviewed Nov 19, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
Snailedlt
Snailedlt reviewed Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me or are the versions a bit larger than the viewbox?
image
image

Edit: It was just me, looks just fine inside of inkscape :)

Snailedlt
Snailedlt approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for another great contribution! 💯 🙇
image
image
image

weh
weh approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

lunatic-fox
lunatic-fox approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👍🏼

@Snailedlt Snailedlt merged commit bb59f4e into devicons:develop Dec 3, 2023
4 checks passed
@lunatic-fox lunatic-fox mentioned this pull request Jan 10, 2024
Merged
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@Snailedlt Snailedlt Snailedlt approved these changes

@weh weh weh approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@canaleal @weh @Snailedlt @lunatic-fox