Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: packer (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2023

Merged
merged 5 commits into from
Dec 3, 2023

Conversation

canaleal
Copy link
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

Used the color #1d94dd for the font SVGs.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 20, 2023
Snailedlt
Snailedlt previously approved these changes Nov 20, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work once again! 💯
The only thing I can think of is that the line-wordmark version's smallest text is a bit hard to read since the line is too thick, so it overlaps on some points.
image
However if we make the line thinner then the rest of the icon becomes harder to read. One solution would be to only change the line thickness on the smallest text. Feel free to experiment with it if you want :)

Previews:
image
image
image
image
image

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be fine now! 👍🏼
Thank you for this contribution! 🚀
image
image
image
image

@Snailedlt Snailedlt merged commit 9a0d8bd into devicons:develop Dec 3, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants