-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icon: travis (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally something I can complain about, LOL! (jk)
I just suggested some very minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Thank you for another great contribution! 💯 🙇
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR is related to #1998
Link to prove your SVG is correct and up-to-date.
Additional Notes
The main Travis logo mark is the engineer with the red mustache and yellow hard hat with T symbol. It was somewhat difficult finding a way to simplify the SVG for the
plain
version, but I decided that it might be best to keep the gray borders and simply remove the fills from the SVGs.The
plain.svg
looks simple enough to be used as theline.svg
, but maybe both should be added?The gray color
#2d3136
was used for the font SVGs.