Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with invalid extract carrier. #3

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Conversation

ProfessorMc
Copy link
Contributor

var _ (opentracing.TextMapWriter) = (*carrierAdapter)(nil)
this will cause opentracing: Invalid Inject/Extract carrier when passed byval.

@ProfessorMc
Copy link
Contributor Author

@devigned Can you take a look at this?

Copy link
Owner

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

TY!

@devigned devigned merged commit a75f219 into devigned:master Dec 2, 2020
@devigned
Copy link
Owner

devigned commented Dec 2, 2020

I'm so sorry for the delay. I must have read the mail, then didn't mark it for follow up. Thank you so much for the message. I'll also tag a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants