Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Language Validation #7

Closed
devinmatte opened this issue Aug 21, 2017 · 3 comments
Closed

Set Language Validation #7

devinmatte opened this issue Aug 21, 2017 · 3 comments

Comments

@devinmatte
Copy link
Owner

Right now there's the function for adding a language:

def lang(self):
    # TODO: Default
    # TODO: Validation
    self.details['lang'] = input("Language " + str(on(["M"], args)) + ": ")

I need to check it against the available languages to pick from to make sure that users can't put in invalid options.

@saifat29
Copy link
Contributor

@devinmatte I would like to work on this, I've never contributed to any Open Source Project.

Here is what I understood -
The user will input a language which needs to be checked against these available languages.

Here are my doubts -

  1. In what form user will input text - in complete form (like "English/english") or in code form (like "en")?
  2. If the user enters wrong input, what response should be given?

@devinmatte
Copy link
Owner Author

@saifat29 I'd love for you to work on this!

So yes I need to check against the available languages.

  1. Use the codes en would be valid while english would not
  2. Look at privacy for an example of what to do with invalid input

@saifat29
Copy link
Contributor

Thank you, all my doubts are solved. I'll do a Pull Request when I'm finished.

saifat29 pushed a commit to saifat29/wasp that referenced this issue Sep 1, 2017
saifat29 pushed a commit to saifat29/wasp that referenced this issue Sep 1, 2017
devinmatte added a commit that referenced this issue Sep 1, 2017
devinmatte added a commit that referenced this issue Sep 1, 2017
saifat29 added a commit to saifat29/wasp that referenced this issue Sep 1, 2017
devinmatte added a commit that referenced this issue Sep 1, 2017
Language Validation - Issue #7
saifat29 added a commit to saifat29/wasp that referenced this issue Sep 1, 2017
devinmatte added a commit that referenced this issue Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants