Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two questions #36

Open
truegoodwill opened this issue Mar 13, 2024 · 2 comments
Open

Two questions #36

truegoodwill opened this issue Mar 13, 2024 · 2 comments
Labels
question Further information is requested

Comments

@truegoodwill
Copy link

truegoodwill commented Mar 13, 2024 •
edited by devlooped-bot
Loading

  1. Is there any plan to allow custom types for the actor class id? I'd like to use the StronglyTypedId package for actor ids.
  2. Assuming the actor AND its command/query/response objects are built ignorant of Orleans, is there any way to also include these message classes into orleans serialization?

Back this issue
Back this issue
@truegoodwill truegoodwill added the bug Something isn't working label Mar 13, 2024
@truegoodwill
Copy link
Author

Lovely work by the way, I'm very happy to find this.

@kzu kzu added question Further information is requested and removed bug Something isn't working labels Jun 13, 2024
@kzu
Copy link
Member

kzu commented Jun 13, 2024

Hi there!

  1. I started exploring strongly typed ids, but haven't made a decision on it yet. Sounds useful, but if you keep implicit conversion from those to string, this library can remain agnostic to that choice. Still undecided.
  2. You still have to annotate the messages with [GenerateSerializer], and that's what brings them into Orleans serialization, and the generated AddCloudActors (generated) API is the one that brings them into Orleans automatically. You have to add that invocation, as shown on the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kzu @truegoodwill