Fixed swizzling crash as soon as AFNetworking was loading #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift is not able to override `+ (void)load` so we swizzled in `+(void)initialize` this caused a crash as soon as AFNetworking (and potentially other code) started swizzling some class that required our swizzled class to load. Fixed by using an objective C category.
|
|
||
| static NSString * RequestHTTPBodyKey = @"kkp_requestHTTPBody"; | ||
|
|
||
| @implementation NSMutableURLRequest (FixCopy) |
There was a problem hiding this comment.
only this is a relevant change (+ removed swift file)
Current coverage is 98.46%
|
|
Not so sure about leaving Alamofire and AFNetworking there |
|
check next PR, that's the reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift is not able to override
+ (void)loadso we swizzled in+(void)initializethis caused a crash as soon as AFNetworking (and potentially other code) started swizzling some class that required our swizzled class to load. Fixed by using an objective C category.PS: will leave AFNetworking and Alamofire in because anyway we will need them for #86