Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show download progress #17

Closed
orhun opened this issue May 7, 2022 · 3 comments · Fixed by #18
Closed

Show download progress #17

orhun opened this issue May 7, 2022 · 3 comments · Fixed by #18

Comments

@orhun
Copy link
Contributor

orhun commented May 7, 2022

Hello!

I think it would be nice to see the download progress especially for assets that are particularly big.

As a reference, I did something like this in the past using indicatif:

rec

I'd be happy to submit a PR if you have plans for implementing this feature 🐻

@devmatteini
Copy link
Owner

Hi @orhun, nice to see you again!

I think it makes sense to use a progress bar instead of just a spinner.

Feel free to submit a PR!

@devmatteini
Copy link
Owner

A quick follow up after the PR was merged:
I changed the progress bar template again 😅.

At the end, I went with this minimal template {spinner:.blue} {msg} {percent}% ({eta}).
I think it provides more feedback than just the spinner, but keeps things simple without that huge bar that didn't fit very well.

dra-progress-bar-minimal-template

@orhun
Copy link
Contributor Author

orhun commented May 11, 2022

At the end, I went with this minimal template {spinner:.blue} {msg} {percent}% ({eta}). I think it provides more feedback than just the spinner, but keeps things simple without that huge bar that didn't fit very well.

That looks even better 👌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants