Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add persistent term to state retrieving benchmark #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add persistent term to state retrieving benchmark #23

wants to merge 2 commits into from

Conversation

polvalente
Copy link
Contributor

I noticed that there was a benchmark about state retrieval which did not include persistent_terms. I added them to the benchmark. However, there is no benchmark for writing speed or for read-write roundtrip speed. Maybe we should add them in a next pull request?

@devonestes
Copy link
Owner

Good idea! There's just a merge conflict, but after that's fixed I think this is a good addition.

@polvalente
Copy link
Contributor Author

Good idea! There's just a merge conflict, but after that's fixed I think this is a good addition.

@devonestes conflicts resolved! I guess most of them were due to some auto-formatter in my editor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polvalente @devonestes