Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#56 implement autocompletion #112
#56 implement autocompletion #112
Changes from 6 commits
9d2d1d9
c3950ef
1da0e6f
c6ff41b
d7db2b0
9b1b9c7
6c2652e
4c35d3a
6dc807b
9996846
4d92d24
4f4116b
fc68138
986dcc6
22991e4
3e99f66
047abe8
67b35db
51d3ae0
2f95364
b4f30b1
e97a52d
0d7af44
cc1a165
7334b5e
3ed6dd4
31d7571
4bc8ce1
ee92a3d
26ba24e
1a6b6f1
3b90ad7
55e3f90
1451913
cf0a668
7b2fd5a
71308fd
223e364
9c05198
776689b
7f7a207
37005ee
e4502a1
62ce9d0
79fde21
ba1ae7d
2460b74
72d79d4
ce01b3c
635e7a6
82cf24d
e05a3af
c2d4f5b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be wrong but if I read the code correctly this is not "initializing" the "completion" but actually "running it interactively" and also executing what the user finally submitted.
Therefore the method name and the JavaDoc is misleading. I would name the method rather something like
runWithInteractiveCompletion
or so...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced with TODO with link to issue.