Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#27: implement tool commandlet for jmc #197

Merged

Conversation

MustaphaOuchen
Copy link
Contributor

@MustaphaOuchen MustaphaOuchen commented Feb 6, 2024

closes #27

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2024

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link
Collaborator

coveralls commented Feb 6, 2024

Pull Request Test Coverage Report for Build 7874571502

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 100 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 56.287%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java 3 88.16%
com/devonfw/tools/ide/tool/LocalToolCommandlet.java 9 53.93%
com/devonfw/tools/ide/process/ProcessContextImpl.java 39 0.0%
com/devonfw/tools/ide/tool/ToolCommandlet.java 49 52.29%
Totals Coverage Status
Change from base Build 7874515172: 0.1%
Covered Lines: 3752
Relevant Lines: 6414

💛 - Coveralls

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your addition of JMC. Looks quite solid to me.
I've added some small CR's and a question about using symlinks instead of copying files.

@tobka777 tobka777 assigned hohwille and unassigned MustaphaOuchen Feb 9, 2024
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Nice fix :)

@hohwille hohwille changed the title Feature/27 implement tool commandlet for jmc #27: implement tool commandlet for jmc Feb 12, 2024
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MustaphaOuchen thanks for your PR. You did not only integrate JMC but also found and fixed a critical problem and prepared for async execution. Great job 👍

I left some comments for improvement but only rather nice to haves so I already mark as approved.
Please have a look but we can merge this today.

@hohwille hohwille added this to the release:2024.02.001 milestone Feb 12, 2024
@hohwille hohwille merged commit 2aa1fa4 into devonfw:main Feb 12, 2024
4 checks passed
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@tobka777 tobka777 added reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. and removed story-review marks PRs that will be presented in the sprint-review labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commandlet jmc Java Mission Control to analyze performance (e.g. JFR data) reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Implement ToolCommandlet for Java Mission Control
6 participants