-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#27: implement tool commandlet for jmc #197
#27: implement tool commandlet for jmc #197
Conversation
Add tags
Add parameter for background process and add TODO comments
Pull Request Test Coverage Report for Build 7874571502Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your addition of JMC. Looks quite solid to me.
I've added some small CR's and a question about using symlinks instead of copying files.
cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Nice fix :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MustaphaOuchen thanks for your PR. You did not only integrate JMC but also found and fixed a critical problem and prepared for async execution. Great job 👍
I left some comments for improvement but only rather nice to haves so I already mark as approved.
Please have a look but we can merge this today.
closes #27
The jmc commandlet has been implemented.
Addressed issue: Implement ToolCommandlet for Java Mission Control #27