Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#267 Correct_nls_configuration #268

Merged
merged 4 commits into from
Apr 2, 2024
Merged

#267 Correct_nls_configuration #268

merged 4 commits into from
Apr 2, 2024

Conversation

CREITZ25
Copy link
Member

@CREITZ25 CREITZ25 commented Mar 25, 2024 •
edited
Loading

Closes #267 Adding the entries for docker and GCViewer in files ide.properties and ide_de.properties.

@CREITZ25
devonfw#267 Correct_nls_configuration
8ca6789 
Adding the entries for docker and GCViewer in files ide.properties and ide_de.properties.
@CREITZ25 CREITZ25 self-assigned this Mar 25, 2024
@coveralls
Copy link
Collaborator

coveralls commented Mar 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8523020811

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 59.041%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/nls/NlsBundle.java 2 76.92%
Totals Coverage Status
Change from base Build 8522343741: -0.03%
Covered Lines: 4249
Relevant Lines: 6922
💛 - Coveralls

@CREITZ25
devonfw#267 Correct_nls_configuration
6c52917 
Adding the entries for docker and GCViewer in files ide.properties and ide_de.properties.
@CREITZ25
devonfw#267 Correct_nls_configuration
6aaa76c 
Adding the entries for docker and GCViewer in files ide.properties and ide_de.properties.
ndemirca
ndemirca approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@ndemirca ndemirca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndemirca ndemirca requested a review from hohwille March 25, 2024 14:08
@CREITZ25 CREITZ25 assigned hohwille and unassigned CREITZ25 Mar 25, 2024
hohwille
hohwille approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 thank you very much for the issue and PR. Proper fix and ready for merge 👍

@hohwille hohwille merged commit aeb6491 into devonfw:main Apr 2, 2024
4 checks passed
@hohwille hohwille added this to the release:2024.04.001 milestone Apr 2, 2024
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@hohwille hohwille added reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. and removed story-review marks PRs that will be presented in the sprint-review labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

@ndemirca ndemirca ndemirca approved these changes

Assignees

@hohwille hohwille

Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.04.001
Development

Successfully merging this pull request may close these issues.

Correct nls configuration for the commandlets docker and gcviewer.
4 participants
@CREITZ25 @coveralls @hohwille @ndemirca