#63: check if inside ide installation for wrapper script #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-vcapgemini
requested changes
Apr 8, 2024
| if (firstCandidate == null) { // no arguments | ||
| if (current.getArgs().isEmpty()) { | ||
| info(getMessageIdeHomeFound()); | ||
| return ProcessResult.SUCCESS; |
There was a problem hiding this comment.
Better remove the return, otherwise we can't show the help if no arguments were provided.
Suggested change
| return ProcessResult.SUCCESS; |
There was a problem hiding this comment.
I do not get this change.
If the firstCandidate was not found, the first argument is not the keyword of a Commandlet.
This can happen e.g. if a add an option to a commandlet (see e.g. #279).
In such case the second for loop below handles the case to find the proper commandlet.
This however has nothing to do with the fact if IDE_HOME was found or not.
|
already fixed in #282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #63
I haven't fully understood this part of the issue:
"Please note that you cannot output the message to std out from ideasy env --bash. So either we need to print it as error or we have to think of a different approach"
With this PR, the following is output:
IDE environment variables have been set for ...to stdout if inside an IDE installationYou are not inside an IDE installation: ...to stderr if outside an IDE installation