Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test to verify help messages are complete, improve help messages #318

Merged
merged 6 commits into from
May 17, 2024

Conversation

hohwille
Copy link
Member

@hohwille hohwille commented May 7, 2024

Improvements on help messages:

  • added test to verify help messages are complete
  • added missing messages to make test green
  • renamed NLS/i18n message files from Ide.properties to Help.properties to avoid confusion with ide.properties and transparency
  • sorted properties alphabetically
  • improved structure of keys: cmd.«commandlet» for commandlet help message and [cmd.«commandlet».](opt|val).«property» for property help message

@hohwille hohwille added help help/usage output documentation Improvements or additions to documentation labels May 7, 2024
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@coveralls
Copy link
Collaborator

coveralls commented May 16, 2024

Pull Request Test Coverage Report for Build 9112441943

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 59.37%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/nls/NlsBundle.java 3 82.05%
Totals Coverage Status
Change from base Build 9110007150: -0.01%
Covered Lines: 4611
Relevant Lines: 7485

💛 - Coveralls

@hohwille
Copy link
Member Author

Will wait for next daily and there announce merge.

@hohwille hohwille added this to the release:2024.05.001 milestone May 17, 2024
@hohwille hohwille merged commit b2754e9 into devonfw:main May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help help/usage output
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants