#463: Set default Maven m2 repository location back to user home

[jan-vcapgemini]

Fixes: #463

Implements:

• added fallback to USER_HOME for mvn repository
• added new testMavenRepositoryPathFallsBackToUserHome to MvnTest
• added environment.properties to mvn test resources (required for proper simulation of USER_HOME)

[coveralls]

Pull Request Test Coverage Report for Build 10297452655

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 4 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.003%) to 62.798%

---

Files with Coverage Reduction	New Missed Lines	%
com/devonfw/tools/ide/context/IdeContext.java	4	61.18%

Totals
Change from base Build 10297332150:	0.003%
Covered Lines:	5530
Relevant Lines:	8468

---

💛 - Coveralls

[hohwille]

@jan-vcapgemini thanks for your PR. I agree it makes absolutely sense to have M2_REPO always configured instead of using null as fallback. Thanks for the observation and fix 👍

One last thing for getMavenRepository():
I tried to delegate such things to the Mvn commandlet and to avoid redundancies.
IMHO it should be done like this:

  default Path getMavenRepository() {

    if (getIdeHome() != null) {
      Mvn mvn = getCommandletManager().getCommandlet(Mvn.class);
      Path mavenConfFolder = mvn.getMavenConfFolder(true);
      return mavenConfFolder.resolve("repository");
    }
    return null;
  }

Then your fix should go to that Mvn.getMavenConfFolder method as otherwise it is inconsistent. That shows again a good example why such redundancies are evil:
You fix something but are not aware that the same code block was copy&pasted somewhere else where you then miss to apply the fix as well...