Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#531: prevent logging from context constructor #559

Merged
merged 6 commits into from
Aug 29, 2024
Merged

#531: prevent logging from context constructor #559

merged 6 commits into from
Aug 29, 2024

Conversation

hohwille
Copy link
Member

fixes #531

  • prevent logging from IdeContext constructor
  • check if debug/trace logging was activated before disabling log-levels for processable output commandlets
  • solve ContextCommandlet init issues

@hohwille hohwille added environment EnvironmentCommandlet, env variables, path, etc. CLI IDEasy command-line-interface (parsing args, etc.) bugfix logging labels Aug 26, 2024
@hohwille hohwille added this to the release:2024.09.001 milestone Aug 26, 2024
@hohwille
Copy link
Member Author

hohwille commented Aug 26, 2024 •
edited
Loading

Waiting for team review...

@coveralls
Copy link
Collaborator

coveralls commented Aug 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10582151471

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 186 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.3%) to 64.829%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/common/SystemPath.java 2 82.78%
com/devonfw/tools/ide/commandlet/ContextCommandlet.java 5 71.74%
com/devonfw/tools/ide/context/IdeContext.java 18 61.18%
com/devonfw/tools/ide/cli/Ideasy.java 18 0.0%
com/devonfw/tools/ide/context/IdeContextConsole.java 24 0.0%
com/devonfw/tools/ide/context/AbstractIdeContext.java 119 58.87%
Totals Coverage Status
Change from base Build 10581933165: -0.3%
Covered Lines: 5728
Relevant Lines: 8523
💛 - Coveralls

jan-vcapgemini
jan-vcapgemini requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your addition of the IdeStartContext. I've added some small CR's but I think overall this is ready to merge.

cli/src/main/java/com/devonfw/tools/ide/context/IdeStartContext.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/context/IdeStartContextmpl.java Outdated Show resolved Hide resolved
jan-vcapgemini
jan-vcapgemini approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the missing javadoc and fixing the typo. Ready for merge.

@hohwille hohwille merged commit f1b1801 into devonfw:main Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

Assignees

@hohwille hohwille

Labels
bugfix CLI IDEasy command-line-interface (parsing args, etc.) environment EnvironmentCommandlet, env variables, path, etc. logging
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.09.001
Development

Successfully merging this pull request may close these issues.

EnvironmentCommandlet can log warnings into the middle of environment variables
3 participants
@hohwille @coveralls @jan-vcapgemini