#640: fix xml merger if merge:id is omitted for repated element #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hohwille
added
configuration
Pull Request Test Coverage Report for Build 10964479083Details
💛 - Coveralls |
… is inherited from previous element
this is O(n^2) and also current code removes merge:* attributes in updateAndRemoveNsAttributes so the parent could be modified and merge:strategy been removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #640
IdComputershall be constructed.id-fallbacktest as already suggested before by @jan-vcapgemini in PR #621: fixed ID fallback for XML merger #622 for bug Xml merger ID fallback not working #621 (due to my "ignorance" we have not immediately found this bug).