-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#593: #651: #564: #439: fixed bugs, refactored tool dependencies #652
Merged
hohwille
merged 8 commits into
devonfw:main
from
hohwille:feature/593-fix-tool-error-handling
Sep 26, 2024
Merged
#593: #651: #564: #439: fixed bugs, refactored tool dependencies #652
hohwille
merged 8 commits into
devonfw:main
from
hohwille:feature/593-fix-tool-error-handling
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tored tool dependencies
…generic step logging for plugins
hohwille
added
enhancement
New feature or request
android-studio
Android Studio IDE from Jet-Brains
vscode
Microsoft visual studio code
npm
node package manager
eclipse
related to Eclipse IDE
intellij
IntelliJ IDE from Jet-Brains
bugfix
process
executing external programs (ProcessContext)
dependency
Tool dependencies (if tool A requires tool B)
labels
Sep 25, 2024
Wow, internal github action infrastructure error:
Never seen anything like this before. GHA usually runs as solid as a rock. |
Pull Request Test Coverage Report for Build 11060995883Details
💛 - Coveralls |
jan-vcapgemini
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to us, we've added some questions and small CRs.
Co-Reviewed by @alfeilex @WorkingAmeise
cli/src/main/java/com/devonfw/tools/ide/tool/eclipse/Eclipse.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/version/GenericVersionRange.java
Show resolved
Hide resolved
This was referenced Sep 27, 2024
hohwille
added a commit
to hohwille/IDEasy
that referenced
this pull request
Sep 30, 2024
hohwille
added a commit
that referenced
this pull request
Sep 30, 2024
hohwille
added
the
reviewed
Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
label
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
android-studio
Android Studio IDE from Jet-Brains
bugfix
dependency
Tool dependencies (if tool A requires tool B)
eclipse
related to Eclipse IDE
enhancement
New feature or request
intellij
IntelliJ IDE from Jet-Brains
npm
node package manager
process
executing external programs (ProcessContext)
reviewed
Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
vscode
Microsoft visual studio code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #593
fixes #651
fixes #564
existsEnvironmentContext
parameterinstallTool
and related stufffixes #439
fixes #356
Sorry, I started this PR small and then found one problem after the next.
This is IMHO a great face-lift but hard to review and can cause lots of conflicts (fortunately not many other PRs open).