Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#593: #651: #564: #439: fixed bugs, refactored tool dependencies #652

Merged
merged 8 commits into from
Sep 26, 2024

Conversation

hohwille
Copy link
Member

fixes #593

  • we were catching our own exception and wrapping CliException into IllegalStateException
  • various other improvement to ProcessErrorHandling

fixes #651

  • run IDE in background
  • refactor all IDE related code, fixed various bugs, lots of cleanup

fixes #564

  • removed pointless existsEnvironmentContext parameter
  • complete refactoring to installTool and related stuff

fixes #439

  • completed tool dependencies to work as initially planned
  • fixed various bugs
  • lots of cleaup, refactoring and rewrite

fixes #356

  • eclipse install plugin without extra window popping up
  • generic step logging for plugins

Sorry, I started this PR small and then found one problem after the next.
This is IMHO a great face-lift but hard to review and can cause lots of conflicts (fortunately not many other PRs open).

@hohwille hohwille added enhancement New feature or request android-studio Android Studio IDE from Jet-Brains vscode Microsoft visual studio code npm node package manager eclipse related to Eclipse IDE intellij IntelliJ IDE from Jet-Brains bugfix process executing external programs (ProcessContext) dependency Tool dependencies (if tool A requires tool B) labels Sep 25, 2024
@hohwille hohwille added this to the release:2024.09.002 milestone Sep 25, 2024
@hohwille
Copy link
Member Author

Wow, internal github action infrastructure error:

Warning: Failed to download action 'https://internal-api.service.iad.github.net/repos/actions/setup-java/tarball/b6e674f4b717d7b0ae3baee0fbe79f498905dfde'. Error: Name or service not known (internal-api.service.iad.github.net:443)
Warning: Back off 14.322 seconds before retry.
Warning: Failed to download action 'https://internal-api.service.iad.github.net/repos/actions/setup-java/tarball/b6e674f4b717d7b0ae3baee0fbe79f498905dfde'. Error: Name or service not known (internal-api.service.iad.github.net:443)
Warning: Back off 10.037 seconds before retry.
Error: Name or service not known (internal-api.service.iad.github.net:443)

Never seen anything like this before. GHA usually runs as solid as a rock.

@coveralls
Copy link
Collaborator

coveralls commented Sep 25, 2024

Pull Request Test Coverage Report for Build 11060995883

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 281 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-0.05%) to 66.053%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/common/Tag.java 1 98.14%
com/devonfw/tools/ide/url/model/file/UrlDependencyFile.java 1 90.0%
com/devonfw/tools/ide/version/VersionLetters.java 2 57.85%
com/devonfw/tools/ide/commandlet/CommandletManager.java 2 83.33%
com/devonfw/tools/ide/tool/tomcat/Tomcat.java 3 74.51%
com/devonfw/tools/ide/tool/jasypt/Jasypt.java 3 79.07%
com/devonfw/tools/ide/process/ProcessContext.java 3 42.11%
com/devonfw/tools/ide/tool/CustomToolCommandlet.java 3 0.0%
com/devonfw/tools/ide/url/model/UrlMetadata.java 3 83.87%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 4 48.84%
Totals Coverage Status
Change from base Build 11060494765: -0.05%
Covered Lines: 6078
Relevant Lines: 8854

💛 - Coveralls

@hohwille hohwille mentioned this pull request Sep 26, 2024
4 tasks
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to us, we've added some questions and small CRs.
Co-Reviewed by @alfeilex @WorkingAmeise

@hohwille hohwille merged commit bacd9ea into devonfw:main Sep 26, 2024
4 checks passed
hohwille added a commit to hohwille/IDEasy that referenced this pull request Sep 30, 2024
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-studio Android Studio IDE from Jet-Brains bugfix dependency Tool dependencies (if tool A requires tool B) eclipse related to Eclipse IDE enhancement New feature or request intellij IntelliJ IDE from Jet-Brains npm node package manager process executing external programs (ProcessContext) reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. vscode Microsoft visual studio code
Projects
Status: ✅ Done
3 participants