Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from dozer to orika #147

Closed
hohwille opened this issue Sep 16, 2019 · 4 comments
Closed

Switch from dozer to orika #147

hohwille opened this issue Sep 16, 2019 · 4 comments
Assignees
@vapadwal
Labels
common Cross cutting stuff easyfix Good for newcomers enhancement New feature or request logic logic layer (business logic, usecases, component facade)
Milestone
release:2020.04.001

Comments

@hohwille
Copy link
Member

As discussed in #72 we shoud finally replace dozer with orika (or if someone comes up with a more suitable replacement and the according support it may also be something else).
However, dozer is slow and more modern solutions like orika with runtime bytecode generation can improve performance massively (bean mapping ~10x faster).
@hohwille hohwille added common Cross cutting stuff enhancement New feature or request logic logic layer (business logic, usecases, component facade) labels Sep 16, 2019
@hohwille hohwille mentioned this issue Sep 16, 2019
Closed
@hohwille hohwille added this to the release:3.3.0 milestone Dec 2, 2019
@hohwille
Copy link
Member Author

hohwille commented Dec 2, 2019 •
edited
Loading

IMHO we should do the following:

  • provide the BeanMapper API still in the current module bean-mapping
  • offer two implementation modules bean-mapping-dozer and bean-mapping-orika each with according implementation and dependencies
  • change archetype incl. config to use bean-mapping-orika. This will suggest new projects to use Orika what is the better alternative to recommend.
  • for simplicity create a migration in devonfw-ide that replaced bean-mapping dependency to bean-mapping-dozer. This is trivial and lets every project with the freedom to decide to migrate or not. Prepared in this PR: https://github.com/devonfw/ide/pull/351/files
  • extend the bean-mapping guide with some information about this.

@hohwille hohwille added the easyfix Good for newcomers label Jan 28, 2020
@vapadwal vapadwal self-assigned this Jan 31, 2020
This was referenced Feb 3, 2020
Merged
Merged
@hohwille
Copy link
Member Author

So we only need to complete and merge PRs and can then close this issue.

hohwille pushed a commit that referenced this issue Feb 17, 2020
@vapadwal
#147: use orika by default (#203)
dbf9499
hohwille pushed a commit to hohwille/devon4j that referenced this issue Feb 17, 2020
@vapadwal @hohwille
devonfw#147: use orika by default (devonfw#203)
f809cc1
hohwille added a commit to hohwille/devon4j that referenced this issue Feb 17, 2020
@hohwille
devonfw#147: devonfw#203: nice2have cleanup for beanmapping
8ce04d0
@hohwille hohwille mentioned this issue Feb 17, 2020
Merged
hohwille added a commit that referenced this issue Feb 18, 2020
@hohwille
#147: #203: cleanup beanmapping (#214)
adeb731
@hohwille
Copy link
Member Author

Only remaining issue is update and merge of PR for devonfw-ide.

maihacke pushed a commit to maihacke/devon4j that referenced this issue Feb 21, 2020
@vapadwal @maihacke
devonfw#147: use orika by default (devonfw#203)
4ce11db
maihacke pushed a commit to maihacke/devon4j that referenced this issue Feb 21, 2020
@hohwille @maihacke
devonfw#147: devonfw#203: cleanup beanmapping (devonfw#214)
708f8cf
@hohwille
Copy link
Member Author

PRs merged so closing as all is done.

@vapadwal vapadwal mentioned this issue Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vapadwal vapadwal

Labels
common Cross cutting stuff easyfix Good for newcomers enhancement New feature or request logic logic layer (business logic, usecases, component facade)
Projects
None yet
Milestone
release:2020.04.001
Development

No branches or pull requests
2 participants
@hohwille @vapadwal