Start of devon4j Project #1
Conversation
There was a problem hiding this comment.
@AbhayChandel thank you so much for this great work. That was really a huge refactoring including lots of namespace changes for both Java as well as maven. You also hit the fully qualified classnames in config files like spring.factories.
Besides I verified locally from your fork that everything is building well.
Very well done. Of course I found some leftovers where oasp can be found (that was initially all over the place). It is good that you did a smart refactoring rather than just doing a stupid string replace of oasp to devon as it sometimes has to be devonfw instead. So we better rework such things manually.
I approve this PR as I think this already has great quality. We will use this PR afterwards to rework that leftovers in a separate PR.
| <artifactId>devon4j</artifactId> | ||
| <version>dev-SNAPSHOT</version> | ||
| </parent> | ||
| <artifactId>devon4j-boms</artifactId> |
There was a problem hiding this comment.
See oasp/oasp4j#653
This is just a notice. Should not block the merge. It may even be better to do the fixes after this huge initial commit.
There was a problem hiding this comment.
Interesting. You already did it nicely but for some reason the github diff does not show it. See #5.
|
|
||
| /** | ||
| * An Implementation of {@link ResponseExceptionMapper} that converts a REST failure {@link Response} compliant with | ||
| * <a href="https://github.com/oasp-forge/oasp4j-wiki/wiki/guide-rest#error-results">OASP REST error specification</a> |
There was a problem hiding this comment.
we will have to fix such links later as well.
|
|
||
| * for https://github.com/oasp-forge/oasp4j-wiki/wiki/oasp-issue-work[Issue creation and resolution] | ||
| * for https://github.com/oasp-forge/oasp4j-wiki/wiki/oasp-code-contributions[Contributions of code] | ||
| * for https://github.com/oasp-forge/oasp4j-wiki/wiki/oasp-documentation[Contributions to documentation] |
There was a problem hiding this comment.
Same here. AFAIK the plan is to use the wikis in the analogue way. So we would complete oasp/oasp4j#639 and then copy the final wiki to devon4j wiki.
Also we should discuss if theses links should now better go to the stable wiki rather than the unofficial one.
| @@ -0,0 +1,3 @@ | |||
| # IMPORTANT | |||
|
|
|||
| The content of this folder and it's subfolders is **public** under https://oasp.github.io/oasp4j | |||
| xsi:type="setup:VariableTask" | ||
| id="mvn.root.oasp4j" | ||
| name="mvn.root.oasp4j" | ||
| value="${workspace.location/oasp4j}" |
There was a problem hiding this comment.
lots of oasp also here including the filename.
| <!--<additionalparam>-Xdoclint:none -source ${java.version}</additionalparam>--> | ||
| <links> | ||
| <link>http://docs.oracle.com/javase/7/docs/api/</link> | ||
| <link>http://oasp.github.io/devon4j/maven/apidocs/</link> |
There was a problem hiding this comment.
oasp needs to be devonfw here.
| /** | ||
| * This is an implementation of {@link ExceptionMapper} that acts as generic exception facade for REST services. It | ||
| * {@link #toResponse(Throwable) maps} {@link Throwable exceptions} to an according HTTP status code and JSON result as | ||
| * defined by <a href="https://github.com/oasp-forge/oasp4j-wiki/wiki/guide-rest#error-results">OASP REST error |
There was a problem hiding this comment.
one more oasp hit. Again also linking to forge wiki rather than stable one.
| xsi:schemaLocation="http://maven.apache.org/plugins/maven-archetype-plugin/archetype-descriptor/1.0.0 http://maven.apache.org/xsd/archetype-descriptor-1.0.0.xsd" | ||
| name="oasp4j-app-template" xmlns="http://maven.apache.org/plugins/maven-archetype-plugin/archetype-descriptor/1.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> | ||
| <id>oasp4j-template-server</id> |
There was a problem hiding this comment.
2x oasp4j. Even more important to fix than Javadoc oasp links.
| public ApplicationObjectMapperFactory() { | ||
|
|
||
| super(); | ||
| // register polymorphic mapping here - see https://github.com/oasp-forge/oasp4j-wiki/wiki/guide-json#json-and-inheritance |
There was a problem hiding this comment.
yet another oasp forge wiki link
| server.context-path=/ | ||
|
|
||
| # Datasource for accessing the database | ||
| # See https://github.com/oasp/oasp4j/wiki/guide-configuration#security |
|
@hohwille I did not migrate the URLs from oasp4j to devon4j on purpose because I was not sure about the new URLs. I will migrate them once the wikis are in place. |
Merge pom changes from develop
Kindly review.