-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decouple mmm and cleanup #18
Conversation
devonfw#9: fixed dependencies so security also works with Java8 and Java9-11
…sed for exception/I18N stuff) oasp/oasp4j#684: replaced AbstractJsonDeserializer with JacksonUtil
My personal suggestion is to include this PR into our first release |
Potential implication for CobiGen:
|
Fine for me. @jdiazgon can you keep track of that? Pleaes create an issue for that in Cobigen referencing this PR? |
Done :) |
…on support we would lose valuable features and making it optional seems to be overcomplicated.
For the record: please do not merge this yet. A review is very welcome. However, I missed some changes/fixes in bean-mapping that I am currently working on. Further I am going to update to |
…also to basic for simplicity, decoupled web component, upgraded to modularized mmm-util and reduced dependency to mmm-util-exception)
now ready. |
Currently travis is unfortunately not serving its prupose as a reliable CI tool. I contacted the support and hope they are going to fix this asap. Meanwhile we have to ignore such travis errors what makes us a little blind for real build errors. However, I can confirm that I successfully ran |
I asked everywhere for reviews on this. @maybeec gave his go - thanks for that. However, we do not have a formal review and no other feedback. I will have to merge this PR in the next days. It would be awesome to have more feedback and a review, but time for release is running out... |
sorry for mixing multiple issues into one PR but whilst working on #14 I hit compile errors in deprecated classes so I removed them to avoid pointless work what is however #13. Same thing happened for oasp/oasp4j#684 on my way.
Summary:
base
orjpa*
do not depend onmmm
any more.GenericEntity
,RevisionedEntity
,PersistenceEntity
andRevisionedPersistentEntity
intodevon4j
(first 2 inbasic
other 2 injpa-basic
).UserSessionAccess
with some more stuff as a bridge to spring-security.mmm
but adjusted it todevon4j
.devon4j-jpa
module.JacksonUtil
and removedAbstractJsonDeserializer
(see Expose exception handling to AbstractJsonDeserializer API oasp/oasp4j#684).cxf-client
andservice
still have explicit dependency onmmm
(currentlymmm-util-core
). But all they need/use is the Exception/UUID/I18N stuff. I have no further plans to remove this as well. With mmm-util-core: further modularization m-m-m/util#250 we could even reduce the dependency tommm-exception
and then namespace/classpath is not "polluted" with StringUtil, etc. anymore.