Exif from PNGs with eXIf chunk #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Bob, thank you for the PR, this should fix #19 Did you see a possible alternative approach from @rexxars in commit sanity-io@6ee2ee2 ? If nothing else it might be good to include the test case here also. |
|
The approach from @rexxars is definitely more elegant, but creates a new buffer, which was something I was trying to avoid. Are you suggesting I include his test in my pull request? |
lovell
approved these changes
Oct 19, 2022
|
Hi all! Is there any status update on when this will be merged into main? |
|
Sure, there's been no other feedback, let's merge. |
|
@lovell thank you so much! 🙌 |
|
how long will the publish new release? thanks. i really need this feature that parse png exif. |
Merged
|
v1.1.0 now available via npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.