Add fuzz testing setup #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… local time zone.
… approach to find the bug).
… chance-generators.
This appears to be sufficient to make the fuzz tests pass.
Avoids spending several seconds when numEntries (read from the EXIF data) is a big number due to the data being corrupt.
…that my fixes were merged.
|
@papandreou Thank you for these tests. I tried running them locally after merging #5 but see a few failures that all look a bit like: expected Buffer([0x45, 0x78, 0x69, 0x66, 0x00, 0x00, 0x4D, 0x4D, 0x00, 0x2A, 0x00, 0x00, 0x00, 0x08, 0x00, 0x0B /* 8142 more */ ]) to either parse or throw documented error
Threw unexpected error: TypeError [ERR_INVALID_ARG_TYPE]: The "offset" argument must be of type number. Received type string
at validateNumber (internal/validators.js:130:11)I realise this PR was opened a while ago, so no worries if you're unable to do so now, but if you do have the time please can you see if there's anything obvious that can be updated/fixed so we can merge this useful feature. |
* master: Exit early in case of unknown or bogus tag type (devongovett#9) Add range checks to guard against invalid input (devongovett#5) 1.0.2 Fix issue devongovett#7 1.0.1 Use UTC time for date objects
lovell
reviewed
Sep 28, 2019
* master: Don't try to use a non-integer as an offset into the buffer (devongovett#14)
|
Brilliant, thank you Andreas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how I found out what to fix in #5
This PR will be marked as failing, but when combined with the fixes in #5 it will succeed.