Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature (LaunchView&LaunchViweCell): Create components and interaction #41

Conversation

PaoloProdossimoLopes
Copy link
Contributor

@PaoloProdossimoLopes PaoloProdossimoLopes commented May 4, 2022

📝 DESCRIPTION:

  • Refactored
  • Fix Unit test
  • add @mainactor
  • Create custom cell

🔗 ASSOCIATED DOCUMENTATION: 

Task Notion
Figma Prototype

📈 UNIT TESTS:

There was some change?

  • NO
  • YES, which?:

There was some addition?

  • NO
  • YES, which?: 

📦 DEPENDENCY:

Some dependencies are added ?

  • NO 
  • YES, which?:  

Some dependencies are changed ?

  • NO 
  • YES, which?:  
     

📣 ACCESSIBILITY

Has there been any change in accessibility ?

  • NO
  • YES, which?: 

Add some accessibility feature ?

  • NO
  • YES, which?: 

🖼 EVIDENCY

  • NO
  • YES, check below:
    Captura de Tela 2022-05-04 às 20 09 17 Captura de Tela 2022-05-04 às 20 10 20

📍 HOW TO TEST:

FLUX: BUILD APP
BRANCH: paolo/feature/LaunchCellView

☑️ CHECK LIST DEV:

  • Have I revised the code?
  • Am I up to date with develop?
  • Removed the prints?
  • Does my code follow the style of the project?
  • Didn't my changes generate warnings?
  • Have my layouts been validated on smaller screens?
  • Have my layouts been validated on larger screens?
  • I didn't add duplicate code!
  • Does not contain loose numbers (magic numbers) 
  • Does not contain loose texts 
  • Respects the naming standard
  • I didn't leave any callbacks with strong references!
  • I didn't add 'Force unwrap' (!)
  • Is the code following the default language defined for project development?
  • The tests are covering >= 70% 
  • My code was reviewed by someone else

@rdgborges rdgborges closed this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants