style(all): fixing pipelines #1163

ollibowers · 2024-07-12T11:45:49Z

created 7 new jobs out of the previous 2.
- seperate lint, typecheck and test jobs for backend and frontend
- one docker build and start prod job that runs if all others pass
- (currently test jobs are disabled as these fixes will come separately)
fixed pylint errors
- for some, i added explicit ignores as i felt they were appropriately broken
- for some, i added explicit ignores with todos, as i do not want to refactor completely until we get tests
- removed some redundant or poorly placed pylint disables
- intentionally left docstring disables in there as we will fix these in a future PR
- similarly, intentionally left circular import ignores as i will fix this next in a utility refactor + user dict removal PR
- reworked the opening to run_app.py, so its less annoying
fixed eslint disables
- removed a bunch of bad eslint disables, only leaving the necessary ones in
- disabled no-console and allowed non-default exports for the api directory
- refactored term planner decently, as the eslint-disable removal required it. this was a much needed refactor and is one step further to getting TermPlanner.tsx readable.
- moved some axios requests into the api folder, so i could remove some other eslint-disables
  - all will be moved in a upcoming PR (currently assigned to a subbie)
- reworked graphical selector slightly to rely more on the unlocked courses route, as previously it was trying to use a .unlocked property on the user courses response (which didn't exist). now we have colors again!!!
verified that there are no mypy type: ignores that we do not want (or that wont get culled by something else very soon)
verified that there are no tsc @ts-nochecks that we do not want
update team.md

github-actions · 2024-07-12T11:48:39Z

Test Results

0 tests - 156 0 ✅ - 80 0s ⏱️ -39s
0 suites - 13 0 💤 - 2
0 files - 2 0 ❌ - 74

Results for commit a4ead88. ± Comparison against base commit f142dab.

♻️ This comment has been updated with latest results.

… checks

…ewline

…rong-import-order Also changed run_app.py checks to no longer require nodemon.

Mostly just added scope pylint disables because I am not refactoring this code.

…rn, consider-using-enumerate

…rn-statements, unspecified-encoding

.github/workflows/ci.yml

…-many-branches, too-many-public-methods Most of this was just disables, as I believe these were used fairly and solemnly.

…ted a /ping route to achieve this

…k otherwise

…directory (until error reporting is standardised)

…ircles into style/all/fix-pylint-and-eslint

… it up a lot

…nding is always false there

…ues in their users

…nlocked doesnt exist on user courses

sachk

not super thorough but lgtm, if you want more feedback u can ask jared since he's more experienced with gh actions.

martanman

lgtm

ollibowers requested review from a team as code owners July 12, 2024 11:45

ollibowers changed the base branch from dev to 331-staging July 12, 2024 12:07

ollibowers changed the title ~~[DRAFT-BECAUSE-I-WANT-CI] style(all): fixing pylint and eslint~~ style(all): fixing pylint and eslint Jul 12, 2024

ollibowers marked this pull request as draft July 12, 2024 12:30

ollibowers added 22 commits July 18, 2024 15:03

wip: re enable pylint for 331-staging

610efbf

wip: trying to disable the frontend tests and adding linting and type…

fe2cb4b

… checks

fix: forgor working directory

c04b8fb

fix: install dotenv for frontend

7ab4df5

wip: add workplace extensions and LF the .gitignore

17162a7

wip: testing out a composite action

38e0bb0

fix: forgor shell from my composite action

0b9a983

wip: fix for pip install dotenv fail

9442a43

wip: i might be dumb

2966e2b

wip: more testing, double python usage

5428c9e

wip: added eslint job to test if it all works

a121e19

fix: wrong lts version

91fdc0e

wip: added first few jobs

de15da0

wip: added the backend jobs

a070aa7

fix: backend tests failed, added wait for backend container

5827e81

chore: removed the old pylinter file

e0c675f

fix: remove shell from sleep

41f4c07

fix: pylint - trailing-whitespace, trailing-newlines, missing-final-n…

3d5d79b

…ewline

fix: pylint - ungrouped-imports, wrong-import-position, reimproted, w…

add84e9

…rong-import-order Also changed run_app.py checks to no longer require nodemon.

fix: style - too-many-locals, too-many-function-args, cell-var-from-loop

f4d1ee9

Mostly just added scope pylint disables because I am not refactoring this code.

fix: pylint - possibly-used-before-assignment, unused-import

6196ebf

fix: pylint - unused-variable

ce6cedd

ollibowers force-pushed the style/all/fix-pylint-and-eslint branch from 88a1e80 to ce6cedd Compare July 18, 2024 15:04

fix: pylint - multiple-statements, redefined-outer-name, no-else-retu…

af90ce4

…rn, consider-using-enumerate

ollibowers added 5 commits July 18, 2024 15:58

fix: pylint - bare-except, use-dict-literal

d162e81

fix: actual troll

6730226

fix: pylint - subprocess-run-check, consider-using-sys-exit

20c1948

fix: pylint - consider-using-with, abstract-method, inconsistent-retu…

7ec57c8

…rn-statements, unspecified-encoding

wip: disable the unit tests for now

bf1fcf1

Peedee2002 reviewed Jul 19, 2024

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

ollibowers added 7 commits July 19, 2024 16:20

fix: pylint - too-many-nested-blocks, too-many-return-statements, too…

70690ec

…-many-branches, too-many-public-methods Most of this was just disables, as I believe these were used fairly and solemnly.

fix: pylint - empty-docstring (and some new todo comments)

0c23ee4

feat: added healthcheck for backend containers to be used in ci, crea…

9d0837b

…ted a /ping route to achieve this

feat: docker build job now requires all other jobs, as pointless chec…

b340949

…k otherwise

fix: re-disabled the backend tests

fa381a5

chore: add 2024 team.md and update previous years for missing members

8652071

chore: add 2022 luke github username

20fa354

ollibowers changed the title ~~style(all): fixing pylint and eslint~~ style(all): fixing pipelines Jul 20, 2024

ollibowers added 11 commits July 20, 2024 16:55

fix: remove test jobs from docker job needs

02e6a43

fix: pylint - remove redundant and leftover pylint disables

ad94b18

fix: eslint - allow console.error and non-default exports in the api …

7a257dc

…directory (until error reporting is standardised)

wip: eslint - removed any redundant eslint-disabled

bf6759e

chore: added some todo comments for backend type removal

8ac4482

Merge branch 'style/all/fix-pylint-and-eslint' of github.com:csesoc/C…

0b10e74

…ircles into style/all/fix-pylint-and-eslint

fix: eslint - removed the eslint-disable from TermPlanner and cleaned…

e93de7c

… it up a lot

fix: changed courseQueries.isPending to be isPlaceholderData since pe…

6ff3586

…nding is always false there

fix: eslint - removed a bunch of unnecessary eslint disables

3fcb934

fix: eslint - moved out two axios calls as to resolve some eslint iss…

345da16

…ues in their users

fix: refactored graph to use unlocked course state for coloring as .u…

502580b

…nlocked doesnt exist on user courses

ollibowers marked this pull request as ready for review July 23, 2024 12:46

sachk approved these changes Jul 23, 2024

View reviewed changes

martanman approved these changes Jul 26, 2024

View reviewed changes

ollibowers merged commit abf05fd into 331-staging Jul 26, 2024
8 checks passed

ollibowers deleted the style/all/fix-pylint-and-eslint branch July 26, 2024 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

style(all): fixing pipelines #1163

style(all): fixing pipelines #1163

ollibowers commented Jul 12, 2024 •

edited

Loading

github-actions bot commented Jul 12, 2024 •

edited

Loading

sachk left a comment

martanman left a comment

style(all): fixing pipelines #1163

style(all): fixing pipelines #1163

Conversation

ollibowers commented Jul 12, 2024 • edited Loading

github-actions bot commented Jul 12, 2024 • edited Loading

Test Results

sachk left a comment

Choose a reason for hiding this comment

martanman left a comment

Choose a reason for hiding this comment

ollibowers commented Jul 12, 2024 •

edited

Loading

github-actions bot commented Jul 12, 2024 •

edited

Loading