Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored to use value from the underlaying resource(as should do a field in nova) #7

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Refactored to use value from the underlaying resource(as should do a field in nova) #7

merged 2 commits into from
Feb 1, 2021

Conversation

y-martini
Copy link
Contributor

This PR introduces breaking changes. Of course you need to compile assets before release.

@Kristories
Copy link
Member

Kristories commented Jan 5, 2021 •
edited
Loading

Hi @yuriy-martini thanks for PR. I will review it asap.

@y-martini
Copy link
Contributor Author

Probably, it would be great to add deprecation notice for \Kristories\Qrcode\Qrcode::text method, so no breaking changes introduced and you can increment the minor version

@Kristories Kristories merged commit b22e1b4 into devtical:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y-martini @Kristories